Skip to content

Commit d758f10

Browse files
authored
Merge pull request #976 from hkad98/jkd/docs
docs: add rule to ruff to check un-documented params
2 parents c7e4360 + a460fd1 commit d758f10

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

gooddata-pandas/gooddata_pandas/data_access.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ def _extract_from_attributes_and_maybe_metrics(
358358
359359
Args:
360360
response (ExecutionResponse): The execution response to extract data from.
361-
catalog (CatalogWorkspaceContent): The catalog workspace content.
361+
attributes (list[CatalogAttribute]): The catalog of attributes.
362362
cols (list[str]): A list of column names.
363363
col_to_attr_idx (dict[str, int]): A mapping of pandas column names to attribute dimension indices.
364364
col_to_metric_idx (dict[str, int]): A mapping of pandas column names to metric dimension indices.

gooddata-sdk/gooddata_sdk/catalog/permission/service.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ def get_declarative_organization_permissions(self) -> list[CatalogDeclarativeOrg
120120
None
121121
122122
Returns:
123-
[CatalogDeclarativeOrganizationPermission]:
123+
list[CatalogDeclarativeOrganizationPermission]:
124124
List of all declarative organization permissions.
125125
"""
126126

@@ -136,8 +136,8 @@ def put_declarative_organization_permissions(
136136
"""Put a list of all declarative organization permissions.
137137
138138
Args:
139-
org_permissions([CatalogDeclarativeOrganizationPermission])
140-
list of declarative organization permissions
139+
org_permissions (list[CatalogDeclarativeOrganizationPermission]):
140+
List of declarative organization permissions.
141141
142142
Returns:
143143
None

gooddata-sdk/gooddata_sdk/catalog/workspace/service.py

+1
Original file line numberDiff line numberDiff line change
@@ -541,6 +541,7 @@ def generate_localized_workspaces(
541541
provision_workspace: Should new workspace for the target language be provisioned?
542542
Including setting of corresponding locales.
543543
store_layouts: Store declarative layouts of all workspaces to disk
544+
place_in_hierarchy (bool): Flag if localized workspace should be placed in the hierarchy.
544545
545546
Returns:
546547
None

pyproject.toml

+3
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ lint.select = [
2121
"SIM",
2222
"UP",
2323
"W", # pycodestyle warnings
24+
"D417", # undocumented-param
2425
]
2526
lint.ignore = [
2627
# rules recommended to be ignored when using ruff format
@@ -44,6 +45,8 @@ target-version = "py39"
4445
[tool.ruff.format]
4546
exclude = ['(gooddata-api-client|.*\.snapshot\..*)']
4647

48+
[tool.ruff.lint.pydocstyle]
49+
convention = "google"
4750

4851
[tool.tbump]
4952
# Uncomment this if your project is hosted on GitHub:

0 commit comments

Comments
 (0)