-
Notifications
You must be signed in to change notification settings - Fork 9.7k
feat(telemetry): Add Semantic logging for to ApiRequestEvents #13912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kiranani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the telemetry system by implementing semantic logging for API request events. The primary goal is to provide a more granular and comprehensive view of API interactions, particularly for generative AI, by capturing additional context such as generation parameters and server details. This enhancement addresses previous concerns about potential data loss in telemetry records, ensuring that a richer, separate log is always available for analysis. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds semantic logging for ApiRequestEvent, which is a great addition for better telemetry. The implementation is solid, with good test coverage for the new functionality. I've found one issue related to adherence to OpenTelemetry semantic conventions, where a response-specific attribute was being incorrectly added to request logs. I've provided a suggestion to fix this.
Summary
Semantic logging was added for ApiResponseEvents and ApiErrorEvents previously. But, as noted here, there may be cases of dropped records. Thus having the request events logged separately can be helpful
Pre-Merge Checklist