-
Notifications
You must be signed in to change notification settings - Fork 9.7k
feat(cli): added --force-interactive flag for non-TTY environments #13981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(cli): added --force-interactive flag for non-TTY environments #13981
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @alexaustin007, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Gemini CLI's flexibility by introducing a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a --force-interactive flag, a valuable feature for using the Gemini CLI in non-TTY environments. The implementation is solid, correctly forking logic between the full Ink UI and a new, simpler line-based interactive mode. The TTY checks and raw mode handling are correctly adjusted. I've found one high-severity issue in the new simple interactive mode where error messages from @ command processing are suppressed, providing a poor debugging experience for the user. My review includes a specific suggestion to fix this.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
Fixes #13924
This PR adds the
--force-interactiveflag to allow Gemini CLI to run in interactive mode from non-TTY environments (Java, Node.js, backend services, IDE integrations).Problem: CLI exits immediately when
process.stdin.isTTYis false, preventing programmatic usage.Solution: New flag overrides TTY detection and uses simple line-based I/O instead of full Ink UI.
Details
Implementation:
--force-interactiveCLI flag with yargssimpleInteractiveCli.tsfor line-based I/O using Node.js readlineisInteractiveModeAllowedKey Features:
Related Issues
Fixes #13924
How to Validate
Test manually: