Hide sessions that don't have user messages

[bl-ue]

Summary

This PR hides sessions that don't have any user messages when listing sessions via /resume and --list-sessions.

Details

Related Issues

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @bl-ue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the session management experience by introducing a mechanism to automatically hide sessions that do not contain any user or assistant messages. This change ensures that users are presented with a cleaner and more relevant list of chat sessions, avoiding clutter from empty or purely system-logged interactions.

Highlights

• Session Filtering Logic: Implemented a new utility function, hasUserOrAssistantMessage, to determine if a session contains actual conversational content (user or Gemini messages), distinguishing it from sessions with only system-generated messages (info, error, warning).
• Enhanced Session Listing: Integrated the new filtering logic into the getAllSessionFiles function, ensuring that when sessions are listed via commands like /resume or --list-sessions, only those with meaningful user or assistant interactions are displayed, improving clarity and user experience.
• Comprehensive Testing: Added extensive unit tests for the hasUserOrAssistantMessage function to cover various message type combinations, and updated SessionSelector tests to validate that sessions without user or assistant messages are correctly excluded from the listings.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully implements the feature to hide chat sessions that do not contain any user or assistant messages, with a well-defined utility function and thorough tests. However, a significant user experience issue arises from this change: sessions with only assistant (gemini) messages are now correctly listed, but will be displayed with the name "Empty conversation". This is because the extractFirstUserMessage function, which determines the session's display name, does not account for assistant messages, which is likely to cause confusion. To resolve this, I recommend modifying extractFirstUserMessage (perhaps renaming it to something more general like extractSessionDisplayName) to consider both user and gemini messages when generating the display name. This will ensure that all listed sessions have a meaningful title, improving usability.

[jackwotherspoon]

Looks like a couple tests are having some issues 😄

[bl-ue]

Hi @jackwotherspoon, thank you for fixing the session browser tests on main! There was another test that was failing for me locally but not in the CI that I also fixed.