Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare [tf] Group as an "extra" for compatibility with pip #19

Open
IamJeffG opened this issue Jan 21, 2025 · 1 comment
Open

Declare [tf] Group as an "extra" for compatibility with pip #19

IamJeffG opened this issue Jan 21, 2025 · 1 comment

Comments

@IamJeffG
Copy link

Currently, the dependencies under [tool.poetry.group.tf.dependencies] in pyproject.toml are not recognized as pip extras. This makes it difficult to get dependencies tensorflow and tensorflow-hub via pip when using perch_hoplite.

Could you update the pyproject.toml to declare "tf" as an extra? I think this would go in the [project.optional-dependencies] section.

This would enable users to get perch_hoplite's transitive dependencies when we install the package like so:

pip install "perch_hoplite[tf] @ git+https://github.com/google-research/perch-hoplite.git"
@sdenton4
Copy link
Collaborator

sdenton4 commented Feb 7, 2025

Hey, Jeff!

I have given this a shot, but I'm getting strange behavior. Here's the PR:
#20

The optional dependency seems to work fine with a local copy, but the expected syntax with installing from github seems not to find the tf optional dependency:
https://github.com/google-research/perch-hoplite/actions/runs/13190083861/job/36821133718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants