Skip to content

Commit 67055d3

Browse files
authored
Merge pull request #226 from davidmorgan/fix-lints
Add ignore_for_files for a few lints to generated files.
2 parents 9aa42e8 + c7601c3 commit 67055d3

40 files changed

+155
-173
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## 4.1.1 (unreleased)
4+
5+
- Generated code now tells the analyzer to ignore prefer_expression_function_bodies
6+
and sort_constructors_first.
7+
8+
39
## 4.1.0
410

511
- Improved annotation handling for corner cases.

benchmark/lib/node.g.dart

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benchmark/lib/simple_value.g.dart

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

benchmark/pubspec.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,16 @@ environment:
1212
dependencies:
1313
browser: any
1414
built_collection: ^1.0.0
15-
built_value: ^4.1.0
15+
# built_value: ^4.1.0
16+
built_value:
17+
path: ../built_value
1618

1719
dev_dependencies:
1820
build: ^0.10.0
1921
build_runner: ^0.4.0
20-
built_value_generator: ^4.1.0
22+
# built_value_generator: ^4.1.0
23+
built_value_generator:
24+
path: ../built_value_generator
2125
source_gen: ^0.7.0
2226
quiver: '>=0.21.0 <0.26.0'
2327
test: any

built_value_generator/lib/built_value_generator.dart

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,16 @@ class BuiltValueGenerator extends Generator {
4646
}
4747
}
4848
}
49-
return '$result';
49+
50+
if (result.isNotEmpty) {
51+
return '// ignore_for_file: annotate_overrides\n'
52+
'// ignore_for_file: prefer_expression_function_bodies\n'
53+
'// ignore_for_file: sort_constructors_first\n'
54+
'\n'
55+
'$result';
56+
} else {
57+
return null;
58+
}
5059
}
5160
}
5261

built_value_generator/lib/src/enum_source_class.g.dart

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

built_value_generator/lib/src/enum_source_field.g.dart

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

built_value_generator/lib/src/enum_source_library.g.dart

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

built_value_generator/lib/src/memoized_getter.g.dart

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

built_value_generator/lib/src/serializer_source_class.g.dart

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)