Merge pull request #48 from davidmorgan/reject-dynamic-fields

Reject dynamic fields.

Author: davidmorgan

CHANGELOG.md

@@ -5,6 +5,7 @@
 - Add checking for correct type arguments for Built and Builder interfaces.
 - Generate empty constructor with semicolon instead of {}.
 - Use ArgumentError.notNull for null errors.
+- Reject dynamic fields.
 
 ## 0.1.5
 

built_value_generator/lib/src/source_field.dart

@@ -116,6 +116,10 @@ abstract class SourceField implements Built<SourceField, SourceFieldBuilder> {
       result.add('Make field $name a getter.');
     }
 
+    if (type == 'dynamic') {
+      result.add('Make field $name have non-dynamic type.');
+    }
+
     if (builderFieldExists &&
         type != typeInBuilder &&
         // TODO(davidmorgan): smarter check for builder types.

built_value_generator/test/built_value_generator_test.dart

@@ -240,6 +240,17 @@ abstract class ValueBuilder extends Builder<Value, ValueBuilder> {
 }'''), contains("1. Make field foo a getter."));
     });
 
+    test('rejects unresolved fields', () async {
+      expect(await generate('''library value;
+import 'package:built_value/built_value.dart';
+part 'value.g.dart';
+abstract class Value extends Built<Value, ValueBuilder> {
+  Value._();
+  factory Value([updates(ValueBuilder b)]) = _\$Value;
+  NotFound get foo;
+}'''), contains("1. Make field foo have non-dynamic type."));
+    });
+
     test('suggests builder fields must be getters', () async {
       expect(await generate('''library value;
 import 'package:built_value/built_value.dart';