Migrate to pkg:lints (#161)

Author: kevmoo

acyclic_steps/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

acyclic_steps/pubspec.yaml

@@ -10,7 +10,7 @@ dependencies:
   meta: ^1.1.7
 dev_dependencies:
   test: ^1.5.1
-  pedantic: ^1.4.0
+  lints: ^1.0.0
 environment:
   sdk: '>=2.12.0 <3.0.0'
 

canonical_json/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

canonical_json/lib/src/decoder.dart

@@ -194,10 +194,10 @@ class Decoder {
       if (_value != char('"')) {
         throw _fail('expected key in map');
       }
-      final key_start = _offset;
+      final keyStart = _offset;
       final key = _readRawString();
       _require(':', 'expected ":" separate key and value in map');
-      entries.add(_RawMapEntry(key, _readValue(), key_start));
+      entries.add(_RawMapEntry(key, _readValue(), keyStart));
     } while (_try(','));
     _require('}', 'expected "," or "}" in map');
     // Validate that keys are sorted

canonical_json/pubspec.yaml

@@ -11,6 +11,6 @@ dependencies:
   unorm_dart: ^0.2.0
 dev_dependencies:
   test: ^1.5.1
-  pedantic: ^1.4.0
+  lints: ^1.0.0
 environment:
   sdk: '>=2.12.0 <3.0.0'

canonical_json/test/canonical_json_test.dart

@@ -37,13 +37,13 @@ void main() {
 
   final prng = Random(42);
   for (var i = 0; i < 50; i++) {
-    final chars = '{}[]abcd \0""""\\\\\\\\\$\$\'\''.split('');
+    final chars = '{}[]abcd 0""""\\\\\\\\\$\$\'\''.split('');
     chars.shuffle(prng);
     testValue('shuffled string ($i)', chars.join(''));
     testValue('shuffled map key ($i)', {chars.join(''): 42});
   }
 
-  [
+  for (var data in [
     '""',
     '"hello world"',
     r'"test\"test"',
@@ -67,21 +67,23 @@ void main() {
     '-120',
     '"Äffin"',
     // Test valid canonical JSON cases.
-  ].forEach((String data) => test('isValidCanonicalJSON($data)', () {
-        final value = json.decode(data);
-        final encoded = canonicalJson.encode(value);
-        expect(utf8.decode(encoded), equals(data));
-        final decoded = canonicalJson.decode(encoded);
-        expect(decoded, equals(value));
-        final encodedAgain = canonicalJson.encode(decoded);
-        expect(encodedAgain, encoded);
-        // TODO: Use json.fuse(utf8) when: http://dartbug.com/46205 is fixed!
-        // final decodedJson = json.fuse(utf8).decode(encoded);
-        final decodedJson = json.decode(utf8.decode(encoded));
-        expect(decodedJson, equals(value));
-      }));
+  ]) {
+    test('isValidCanonicalJSON($data)', () {
+      final value = json.decode(data);
+      final encoded = canonicalJson.encode(value);
+      expect(utf8.decode(encoded), equals(data));
+      final decoded = canonicalJson.decode(encoded);
+      expect(decoded, equals(value));
+      final encodedAgain = canonicalJson.encode(decoded);
+      expect(encodedAgain, encoded);
+      // TODO: Use json.fuse(utf8) when: http://dartbug.com/46205 is fixed!
+      // final decodedJson = json.fuse(utf8).decode(encoded);
+      final decodedJson = json.decode(utf8.decode(encoded));
+      expect(decodedJson, equals(value));
+    });
+  }
 
-  [
+  for (var data in [
     '42.1',
     't',
     'f',
@@ -118,19 +120,23 @@ void main() {
     '-0',
     '"A\u0308ffin"', // not unicode normalization form C
     // Test invalid canonical JSON cases.
-  ].forEach((String data) => test('isInvalidCanonicalJSON($data)', () {
-        final raw = utf8.encode(data);
-        expect(() => canonicalJson.decode(raw),
-            throwsA(TypeMatcher<InvalidCanonicalJsonException>()));
-      }));
+  ]) {
+    test('isInvalidCanonicalJSON($data)', () {
+      final raw = utf8.encode(data);
+      expect(() => canonicalJson.decode(raw),
+          throwsA(TypeMatcher<InvalidCanonicalJsonException>()));
+    });
+  }
 
-  [
+  for (var data in [
     1.2,
     -0.0,
-  ].forEach((Object data) => test('cannotBeCanonicalized($data)', () {
-        expect(() => canonicalJson.encode(data),
-            throwsA(TypeMatcher<ArgumentError>()));
-      }));
+  ]) {
+    test('cannotBeCanonicalized($data)', () {
+      expect(() => canonicalJson.encode(data),
+          throwsA(TypeMatcher<ArgumentError>()));
+    });
+  }
 
   test('unicode normalization form C', () {
     final nonFormC = 'A\u0308\uFB03n';

chunked_stream/analysis_options.yaml

@@ -1 +1,5 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml
+
+analyzer:
+  errors:
+    deprecated_member_use_from_same_package: ignore

chunked_stream/pubspec.yaml

@@ -10,6 +10,6 @@ dependencies:
   meta: ^1.3.0
 dev_dependencies:
   test: ^1.16.0
-  pedantic: ^1.4.0
+  lints: ^1.0.0
 environment:
   sdk: ">=2.12.0 <3.0.0"

http_methods/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

http_methods/pubspec.yaml

@@ -10,4 +10,4 @@ environment:
   sdk: '>=2.12.0 <3.0.0'
 dev_dependencies:
   test: ^1.16.0
-  pedantic: ^1.10.0
+  lints: ^1.0.0

neat_cache/CHANGELOG.md

@@ -1,3 +1,5 @@
+## v2.0.2-dev
+
 ## v2.0.1
  * Fixed issue when adding multiple commands without waiting for them to complete first.
 

neat_cache/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

neat_cache/lib/src/providers/resp.dart

@@ -228,7 +228,9 @@ class RespClient {
       _pending.clear();
       final e = RedisConnectionException._('redis client forcibly closed');
       final st = StackTrace.current;
-      pending.forEach((c) => c.completeError(e, st));
+      for (var c in pending) {
+        c.completeError(e, st);
+      }
     }
     await _input.cancel();
 
@@ -247,7 +249,9 @@ class RespClient {
     final pending = _pending.toList(growable: false);
     _pending.clear();
     scheduleMicrotask(() {
-      pending.forEach((c) => c.completeError(e, st));
+      for (var c in pending) {
+        c.completeError(e, st);
+      }
     });
 
     if (!_closed.isCompleted) {

neat_cache/pubspec.yaml

@@ -1,5 +1,5 @@
 name: neat_cache
-version: 2.0.1
+version: 2.0.2-dev
 description: |
   A neat cache abstraction for wrapping in-memory or redis caches.
 homepage: https://github.com/google/dart-neats/tree/master/neat_cache
@@ -13,6 +13,6 @@ dependencies:
   meta: ^1.4.0
 dev_dependencies:
   test: ^1.5.1
-  pedantic: ^1.4.0
+  lints: ^1.0.0
 environment:
   sdk: '>=2.12.0 <3.0.0'

neat_periodic_task/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

neat_periodic_task/lib/neat_periodic_task.dart

@@ -15,9 +15,11 @@
 library neat_periodic_task;
 
 import 'dart:async' show Future, Completer, scheduleMicrotask, TimeoutException;
-import 'package:retry/retry.dart' show RetryOptions;
+
 import 'package:logging/logging.dart' show Logger;
+import 'package:retry/retry.dart' show RetryOptions;
 import 'package:slugid/slugid.dart' show Slugid;
+
 import 'src/neat_status.dart' show NeatTaskStatus;
 
 final _log = Logger('neat_periodic_task');
@@ -88,11 +90,9 @@ class _NeatStatusProviderWithRetry extends NeatStatusProvider {
   final RetryOptions _r;
   _NeatStatusProviderWithRetry(this._provider, this._r);
   @override
-  Future<List<int>?> get() =>
-      _r.retry(() => _provider.get(), retryIf: (e) => e is Exception);
+  Future<List<int>?> get() => _r.retry(() => _provider.get());
   @override
-  Future<bool> set(List<int> status) =>
-      _r.retry(() => _provider.set(status), retryIf: (e) => e is Exception);
+  Future<bool> set(List<int> status) => _r.retry(() => _provider.set(status));
 }
 
 /// Interface for a periodic task.

neat_periodic_task/pubspec.yaml

@@ -15,7 +15,7 @@ dependencies:
   collection: ^1.15.0
 dev_dependencies:
   test: ^1.16.5
-  pedantic: ^1.10.0
+  lints: ^1.0.0
   build_runner: ^1.3.1
   build_verify: ^1.1.1
   json_serializable: ^4.0.2

pem/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

pem/pubspec.yaml

@@ -11,7 +11,7 @@ dependencies:
   petitparser: ^4.0.2
 dev_dependencies:
   test: ^1.16.5
-  pedantic: ^1.10.0
+  lints: ^1.0.0
 environment:
   sdk: '>=2.12.0 <3.0.0'
 

retry/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

retry/pubspec.yaml

@@ -8,6 +8,6 @@ repository: https://github.com/google/dart-neats.git
 issue_tracker: https://github.com/google/dart-neats/labels/pkg:retry
 dev_dependencies:
   test: ^1.16.0-nullsafety.13
-  pedantic: ^1.4.0
+  lints: ^1.0.0
 environment:
   sdk: ">=2.12.0 <3.0.0"

safe_url_check/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

safe_url_check/pubspec.yaml

@@ -15,6 +15,6 @@ dependencies:
 
 dev_dependencies:
   test: ^1.5.1
-  pedantic: ^1.4.0
+  lints: ^1.0.0
   build_runner: ^1.7.2
   build_version: ^2.0.1

sanitize_html/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

sanitize_html/pubspec.yaml

@@ -11,7 +11,7 @@ dependencies:
   meta: ^1.1.7
 dev_dependencies:
   test: ^1.5.1
-  pedantic: ^1.4.0
+  lints: ^1.0.0
   markdown: ^4.0.0
 environment:
   sdk: '>=2.12.0 <3.0.0'

shelf_router/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

shelf_router/pubspec.yaml

@@ -12,7 +12,7 @@ dependencies:
   http_methods: ^1.1.0
 dev_dependencies:
   test: ^1.16.0
-  pedantic: ^1.10.0
+  lints: ^1.0.0
   http: ^0.13.0
 environment:
   sdk: '>=2.12.0 <3.0.0'

shelf_router_generator/analysis_options.yaml

@@ -1,4 +1,4 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml
 
 analyzer:
   strong-mode:

shelf_router_generator/pubspec.yaml

@@ -21,7 +21,7 @@ dev_dependencies:
   build_runner: ^2.0.0
   build_verify: ^2.0.0
   http: ^0.13.0
-  pedantic: ^1.4.0
+  lints: ^1.0.0
   test: ^1.5.3
 
 environment:

shelf_router_generator/test/server/service.dart

@@ -15,8 +15,10 @@
 // @dart=2.12
 
 import 'dart:async' show Future, FutureOr;
+
 import 'package:shelf/shelf.dart';
 import 'package:shelf_router/shelf_router.dart';
+
 import 'api.dart';
 import 'unrelatedannotation.dart';
 
@@ -39,7 +41,7 @@ class Service {
 
   @Route.get('/hi/<user>')
   Future<Response> _hi(Request request) async {
-    final name = params(request, 'user');
+    final name = request.params['user'];
     return Response.ok('hi $name');
   }
 

slugid/analysis_options.yaml

@@ -1 +1 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml

slugid/lib/slugid.dart

@@ -21,11 +21,13 @@
 library slugid;
 
 import 'dart:convert';
-import 'src/random.dart';
 import 'dart:typed_data';
+
 import 'package:convert/convert.dart';
 import 'package:meta/meta.dart' show sealed;
 
+import 'src/random.dart';
+
 final _uuidPattern = RegExp(
     r'[0-9a-fA-F]{8}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{4}\-[0-9a-fA-F]{12}');
 
@@ -119,7 +121,7 @@ class Slugid {
   ///
   /// This method also accepts string representations of slugids and UUIDs.
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     // If other is a string we try to decode it.
     if (other is String) {
       try {
@@ -139,4 +141,7 @@ class Slugid {
     }
     return false;
   }
+
+  @override
+  int get hashCode => Object.hashAll(_bytes);
 }

slugid/pubspec.yaml

@@ -1,16 +1,20 @@
 name: slugid
-version: 1.1.0
+version: 1.1.1
 description: |
   A URL-safe base64 encoding for UUIDv4 stripped of padding. Useful when
   embedding short random UUIDs in URLs.
 homepage: https://github.com/google/dart-neats/tree/master/slugid
 repository: https://github.com/google/dart-neats.git
 issue_tracker: https://github.com/google/dart-neats/labels/pkg:slugid
+
+environment:
+  sdk: '>=2.14.0 <3.0.0'
+
 dependencies:
-  convert: ^3.0.0-nullsafety.0
-  meta: ^1.3.0-nullsafety.6
+  convert: ^3.0.0
+  meta: ^1.3.0
+
 dev_dependencies:
-  test: ^1.16.0-nullsafety.12
-  pedantic: ^1.10.0-nullsafety.3
-environment:
-  sdk: '>=2.12.0 <3.0.0'
+  test: ^1.16.0
+  lints: ^1.0.0
+