Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

gitiles lacks responsive design #235

Open
avm99963 opened this issue Aug 14, 2021 · 3 comments
Open

gitiles lacks responsive design #235

avm99963 opened this issue Aug 14, 2021 · 3 comments

Comments

@avm99963
Copy link

Gitiles isn't optimized for small screens (mobile, mainly). It would be awesome if we added responsive design so it adapts to small screens, what do you think?

I'd be willing to contribute changes towards this direction.

@jrn
Copy link
Contributor

jrn commented Aug 17, 2021

Sure, a CSS change to improve that would be welcome!

See https://gerrit.googlesource.com/gitiles/+/HEAD/Documentation/developer-guide.md for contribution instructions.

@avm99963
Copy link
Author

Awesome, I'll get to that soon then :)

@avm99963
Copy link
Author

I've made some progress in CLs 327080 and 327120. I'm not fully happy with the last one since it uses a CSS property which is not correctly implemented in Safari and has an accessibility issue, but I'm happy with sending the first one for review.

@jrn: I don't know how you do code review in the gitiles project, but if you're fine with that, I can add you as a reviewer of the first change.

These are some screenshots showing what's changed:

Before (current HEAD) After CL 327080
home_now home_responsive
repoindex_now repoindex_responsive
tree_now tree_responsive
file_now file_responsive
log_now log_responsive
doc_now doc_responsive

Also, here is a comparison of the commit page, which is improved in the 2nd CL:

Before (current HEAD) After CL 327080 After CL 327120
commit_now commit_responsive1 commit_responsive2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants