Skip to content

Commit 7ac5642

Browse files
cushonronshapiro
authored andcommitted
Remove line breaks between param comments and params
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=154233543
1 parent b713ffd commit 7ac5642

File tree

3 files changed

+33
-4
lines changed

3 files changed

+33
-4
lines changed

core/src/main/java/com/google/googlejavaformat/java/JavaInput.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,14 @@ private static ImmutableList<Token> buildTokens(List<Tok> toks) {
487487
OUTERMOST:
488488
while (k < kN) {
489489
while (!toks.get(k).isToken()) {
490-
toksBefore.add(toks.get(k++));
490+
Tok tok = toks.get(k++);
491+
toksBefore.add(tok);
492+
if (isParamComment(tok)) {
493+
while (toks.get(k).isNewline()) {
494+
// drop newlines after parameter comments
495+
k++;
496+
}
497+
}
491498
}
492499
Tok tok = toks.get(k++);
493500

@@ -543,8 +550,7 @@ private static ImmutableList<Token> buildTokens(List<Tok> toks) {
543550

544551
private static boolean isParamComment(Tok tok) {
545552
return tok.isSlashStarComment()
546-
&& tok.getText().endsWith("*/")
547-
&& tok.getText().substring(0, tok.getText().length() - "*/".length()).trim().endsWith("=");
553+
&& tok.getText().matches("\\/\\*[A-Za-z0-9\\s_\\-]+=\\s*\\*\\/");
548554
}
549555

550556
/**

core/src/test/resources/com/google/googlejavaformat/java/testdata/B26694550.input

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,20 @@
11
class B26694550 {
22
{
3+
/* === not a param comment */
34
fffffffffffffffffffffffffffffff(
4-
ImmutableList.copyOf(keys), /*keepGoing=*/
5+
ImmutableList.copyOf(keys), /*&=*//*keepGoing=*/
6+
false,
7+
ggggggggggggggggggggggggggggggggggggggggggg);
8+
fffffffffffffffffffffffffffffff(
9+
ImmutableList.copyOf(keys),
10+
/*keepGoing=*/
11+
false,
12+
ggggggggggggggggggggggggggggggggggggggggggg);
13+
fffffffffffffffffffffffffffffff(
14+
ImmutableList.copyOf(keys),
15+
/*foo_bar=*/
16+
false,
17+
/*foo-bar=*/
518
false,
619
ggggggggggggggggggggggggggggggggggggggggggg);
720
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,18 @@
11
class B26694550 {
22
{
3+
/* === not a param comment */
4+
fffffffffffffffffffffffffffffff(
5+
ImmutableList.copyOf(keys), /*&=*/
6+
/*keepGoing=*/ false,
7+
ggggggggggggggggggggggggggggggggggggggggggg);
38
fffffffffffffffffffffffffffffff(
49
ImmutableList.copyOf(keys),
510
/*keepGoing=*/ false,
611
ggggggggggggggggggggggggggggggggggggggggggg);
12+
fffffffffffffffffffffffffffffff(
13+
ImmutableList.copyOf(keys),
14+
/*foo_bar=*/ false,
15+
/*foo-bar=*/ false,
16+
ggggggggggggggggggggggggggggggggggggggggggg);
717
}
818
}

0 commit comments

Comments
 (0)