Skip to content

Java nested lambdas formatting is incredibly poor (attempt 2) #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kberezin-nshl opened this issue Dec 11, 2023 · 1 comment
Closed

Java nested lambdas formatting is incredibly poor (attempt 2) #1006

kberezin-nshl opened this issue Dec 11, 2023 · 1 comment

Comments

@kberezin-nshl
Copy link

IMPORTANT: I am NOT asking to add a capability of switching the formatter OFF here, I am reporting a PROBLEM with the formatter: it expands what should be 7-8 lines of code into 20-ish lines of code. I am asking to reconsider the approach of Java lambda's formatting.

This issue was incorrectly closed as a duplicate of unrelated issue. Reopening:

Elasticsearch API. What I would like to have:

      var hits =
          elasticsearchClient
              .search(r -> r.index(indexName)
                  .query(q -> q.bool(
                      b -> b
                          .must(job -> job.match(t -> t.field("job_id").query(jobId)))
                          .must(str -> str.queryString(
                              qs -> qs.query("\"%s\"".formatted(searchString))))))
                  .size(request.getPageSize()),
                  Doc.class);

what I get:

      var hits =
          elasticsearchClient
              .search(
                  r ->
                      r.index(indexName)
                          .query(
                              q ->
                                  q.bool(
                                      b ->
                                          b.must(
                                                  job ->
                                                      job.match(
                                                          t -> t.field("job_id").query(jobId)))
                                              .must(
                                                  str ->
                                                      str.queryString(
                                                          qs ->
                                                              qs.query(
                                                                  "\"%s\""
                                                                      .formatted(searchString))))))
                          .size(request.getPageSize()),
                  Doc.class);
@cushon
Copy link
Collaborator

cushon commented Dec 18, 2023

I replied in #990

@cushon cushon closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants