Skip to content

Commit 2af4d05

Browse files
authored
Allow columns CSS property to accept int/str vals. (#86)
The columns property allows int/strs according to https://developer.mozilla.org/en-US/docs/Web/CSS/columns We want to keep the int value for backwards compatibility. Fixes #79
1 parent fcabaae commit 2af4d05

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mesop/component_helpers/style.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ class Style:
173173
box_sizing: str | None = None
174174
color: str | None = None
175175
column_gap: int | str | None = None
176-
columns: int | None = None
176+
columns: int | str | None = None
177177
cursor: str | None = None
178178
display: Literal[
179179
# precomposed values
@@ -273,7 +273,7 @@ def to_style_proto(s: Style) -> pb.Style:
273273
box_sizing=s.box_sizing,
274274
color=s.color,
275275
column_gap=_px_str(s.column_gap),
276-
columns=s.columns,
276+
columns=str(s.columns),
277277
cursor=s.cursor,
278278
display=s.display,
279279
flex_basis=s.flex_basis,

mesop/protos/ui.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ message Style {
228228
optional string box_sizing = 47;
229229
optional string color = 4;
230230
optional string column_gap = 33;
231-
optional int32 columns = 5;
231+
optional string columns = 5;
232232
optional string cursor = 46;
233233
optional string display = 6;
234234
optional string flex_basis = 7;

0 commit comments

Comments
 (0)