Skip to content

Commit 62562fe

Browse files
authored
Fix changelog, bump min SDK (#488)
1 parent 2dcb6b0 commit 62562fe

15 files changed

+132
-100
lines changed

.github/workflows/dart.yml

+13-13
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

analysis_options.yaml

+15
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,25 @@ linter:
3434
- cancel_subscriptions
3535
- cascade_invocations
3636
- collection_methods_unrelated_type
37+
- combinators_ordering
3738
- comment_references
39+
- conditional_uri_does_not_exist
3840
- constant_identifier_names
3941
- control_flow_in_finally
4042
- curly_braces_in_flow_control_structures
43+
- dangling_library_doc_comments
4144
- depend_on_referenced_packages
4245
- directives_ordering
4346
- empty_catches
4447
- empty_constructor_bodies
4548
- empty_statements
49+
- exhaustive_cases
4650
- file_names
4751
- hash_and_equals
4852
- implementation_imports
53+
- implicit_call_tearoffs
4954
- join_return_with_assignment
55+
- library_annotations
5056
- library_names
5157
- library_prefixes
5258
- library_private_types_in_public_api
@@ -57,6 +63,7 @@ linter:
5763
- no_leading_underscores_for_library_prefixes
5864
- no_leading_underscores_for_local_identifiers
5965
- no_runtimeType_toString
66+
- no_wildcard_variable_uses
6067
- non_constant_identifier_names
6168
- null_check_on_nullable_type_parameter
6269
- null_closures
@@ -97,34 +104,42 @@ linter:
97104
- provide_deprecation_message
98105
- recursive_getters
99106
- require_trailing_commas
107+
- secure_pubspec_urls
100108
- slash_for_doc_comments
101109
- sort_pub_dependencies
102110
- sort_unnamed_constructors_first
103111
- test_types_in_equals
104112
- throw_in_finally
105113
- type_annotate_public_apis
106114
- type_init_formals
115+
- type_literal_in_constant_pattern
107116
- unawaited_futures
108117
- unnecessary_brace_in_string_interps
109118
- unnecessary_const
110119
- unnecessary_constructor_name
111120
- unnecessary_getters_setters
112121
- unnecessary_lambdas
113122
- unnecessary_late
123+
- unnecessary_library_directive
124+
- unnecessary_library_name
114125
- unnecessary_new
115126
- unnecessary_null_aware_assignments
116127
- unnecessary_null_in_if_null_operators
117128
- unnecessary_nullable_for_final_variable_declarations
118129
- unnecessary_overrides
119130
- unnecessary_parenthesis
120131
- unnecessary_statements
132+
- unnecessary_string_escapes
121133
- unnecessary_string_interpolations
122134
- unnecessary_this
135+
- unnecessary_to_list_in_spreads
136+
- unreachable_from_main
123137
- unrelated_type_equality_checks
124138
- use_function_type_syntax_for_parameters
125139
- use_is_even_rather_than_modulo
126140
- use_rethrow_when_possible
127141
- use_string_buffers
142+
- use_string_in_part_of_directives
128143
- use_super_parameters
129144
- valid_regexps
130145
- void_checks

mono_repo/CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## 6.6.2
2+
3+
- Require Dart `sdk: ^3.4.0`.
4+
- Populate `token` for `codecov` action.
5+
(Requires the user to provide `CODECOV_TOKEN` in their secrets.)
6+
- Update to latest action versions.
7+
18
## 6.6.1
29

310
- Update to latest action versions.

mono_repo/lib/src/commands/github/action_versions.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
/// This file is generated, and should not be modified by hand.
6-
///
7-
/// To regenerate it, run the `tool/generate_action_versions.dart` script.
5+
// This file is generated, and should not be modified by hand.
6+
//
7+
// To regenerate it, run the `tool/generate_action_versions.dart` script.
88

99
const actionsCacheVersion = '0c45773b623bea8c8e75f6c82b208c3cf94ea4f9';
1010
const dartLangSetupDartVersion = '0a8a0fc875eb934c15d08629302413c671d3f672';

mono_repo/lib/src/mono_config.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class MonoConfig implements BasicConfiguration {
7070

7171
Map parseCI(CI targetCI) {
7272
final key = targetCI.toString().split('.').last;
73-
final value = json[key] ?? {};
73+
final value = json[key] ?? <String, dynamic>{};
7474

7575
if (value is bool) {
7676
if (!value) {

mono_repo/lib/src/version.dart

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mono_repo/pubspec.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,23 @@ name: mono_repo
22
description: >-
33
CLI tools to make it easier to manage a single source repository containing
44
multiple Dart packages.
5-
version: 6.6.1
5+
version: 6.6.2
66
repository: https://github.com/google/mono_repo.dart
77

88
topics:
99
- tool
1010
- repository-management
1111

1212
environment:
13-
sdk: ^3.0.0
13+
sdk: ^3.4.0
1414

1515
dependencies:
1616
args: ^2.0.0
1717
checked_yaml: ^2.0.0
1818
collection: ^1.14.3
1919
graphs: ^2.2.0
2020
io: ^1.0.0
21-
json_annotation: ^4.8.0
21+
json_annotation: ^4.9.0
2222
meta: ^1.0.0
2323
path: ^1.4.1
2424
pub_semver: ^2.0.0

mono_repo/test/action_versions_test.dart

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
// On windows this test fails for unknown reasons, possibly there are carriage
66
// returns being introduced during formatting.
77
@OnPlatform({'windows': Skip('Broken on windows')})
8+
library;
9+
810
import 'dart:io';
911

1012
import 'package:test/test.dart';

mono_repo/test/ensure_build_test.dart

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
@Tags(['presubmit-only'])
66
@OnPlatform({'windows': Skip('newlines are different')})
77
@Timeout.factor(4)
8+
library;
9+
810
import 'package:build_verify/build_verify.dart';
911
import 'package:test/test.dart';
1012

mono_repo/test/github_command_test.dart

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// ignore_for_file: inference_failure_on_collection_literal
6+
57
import 'package:mono_repo/src/github_config.dart';
68
import 'package:mono_repo/src/yaml.dart';
79
import 'package:term_glyph/term_glyph.dart' as glyph;

mono_repo/test/mono_config_test.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ final _dummyPubspec = Pubspec('_example');
1818
String _encodeJson(Object? input) =>
1919
const JsonEncoder.withIndent(' ').convert(input);
2020

21-
PackageConfig _parse(map) => PackageConfig.parse(
21+
PackageConfig _parse(Object map) => PackageConfig.parse(
2222
'a',
2323
_dummyPubspec,
2424
map is YamlMap
@@ -122,7 +122,7 @@ line 2, column 9: Unsupported value for "sdk". The value for "sdk" must be an ar
122122

123123
test('sdk value cannot be empty', () {
124124
_expectParseThrows(
125-
{'sdk': []},
125+
{'sdk': <Never>[]},
126126
r'''
127127
line 2, column 9: Unsupported value for "sdk". The value for "sdk" must be an array with at least one value.
128128
@@ -246,7 +246,7 @@ line 10, column 6: Must have one and only one key of `format`, `analyze`, `test`
246246
final monoYaml = {
247247
'sdk': ['stable'],
248248
'stages': [
249-
{'a': []},
249+
{'a': <Never>[]},
250250
],
251251
};
252252
_expectParseThrows(
@@ -281,7 +281,7 @@ line 8, column 4: Stages must be a list of maps with exactly one key (the name o
281281
test('no keys under a stage', () {
282282
final monoYaml = {
283283
'sdk': ['stable'],
284-
'stages': [{}],
284+
'stages': [<String, dynamic>{}],
285285
};
286286
_expectParseThrows(
287287
monoYaml,

mono_repo/test/presubmit_command_test.dart

+2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
@Tags(['presubmit-only'])
66
@OnPlatform({'windows': Skip('Cant run shell scripts on windows')})
7+
library;
8+
79
import 'dart:io';
810

911
import 'package:io/ansi.dart';

0 commit comments

Comments
 (0)