Building with SCIP breaks: Target SCIP::libscip not available

[yurivict]

What version of OR-Tools and what language are you using?
Version: 9.14
Language: C++

Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)
n/a

What operating system (Linux, Windows, ...) and version?
FreeBSD 15

What did you do?
Steps to reproduce the behavior:
build

What did you expect to see
n/a

What did you see instead?

CMake Error at cmake/check_deps.cmake:111 (message):
  Target SCIP::libscip not available.
Call Stack (most recent call first):
  CMakeLists.txt:453 (include)

Anything else we should know about your project / environment

SCIP-10.0.0
clang-19

[Mizux]

last SCIP release is v9.2.4 (we use 9.2.3 IIRC) where SCIP 10.0.0 comes from ?

ref: https://github.com/scipopt/scip/releases/tag/v924

[Mizux]

when using FetchContent SCIP do provide SCIP::libscip target alias...
https://github.com/scipopt/scip/blob/v924/src/CMakeLists.txt#L1083

Unfortunately they do not use this NAMEPSACE in the cmake install(export rule
ref:

• https://cmake.org/cmake/help/latest/command/install.html#export
• https://github.com/scipopt/scip/blob/v924/src/CMakeLists.txt#L1193

BUT we should add it if not found

or-tools/cmake/system_deps.cmake

Lines 96 to 104 in 8f2433d

	if(USE_SCIP)
	if(NOT BUILD_SCIP AND NOT TARGET SCIP::libscip)
	find_package(SCIP REQUIRED)
	if(TARGET libscip AND NOT TARGET SCIP::libscip)
	message(WARNING "SCIP::libscip not provided")
	add_library(SCIP::libscip ALIAS libscip)
	endif()
	endif()
	endif()

note: when using foo::bar cmake issue a error if the target is not found, otherwise if using bar not knowing if it a CMake target or a library name cmake will add a -lbar if no cmake target is found leading to a linking error during the build later...
note: I can't find the SCIP issue related to it, maybe I need to (re)open a new one...

[Mizux]

Seems this patch has been done after the 9.14 release...
9d3350d

[yurivict]

https://www.scipopt.org/download/release/scip-10.0.0.tgz