Skip to content

Commit 0c8445c

Browse files
authored
fix: Ignore linux source packages (#1523)
Linux source packages are likely to be kernel packages, which generally do not apply in a container context,
1 parent 1ad4d20 commit 0c8445c

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

pkg/osvscanner/filter.go

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,28 @@ func filterUnscannablePackages(r reporter.Reporter, scanResults *results.ScanRes
3535
scanResults.PackageScanResults = packageResults
3636
}
3737

38+
// filterNonContainerRelevantPackages removes packages that are not relevant when doing container scanning
39+
func filterNonContainerRelevantPackages(r reporter.Reporter, scanResults *results.ScanResults) {
40+
packageResults := make([]imodels.PackageScanResult, 0, len(scanResults.PackageScanResults))
41+
for _, psr := range scanResults.PackageScanResults {
42+
p := psr.PackageInfo
43+
44+
// Almost all packages with linux as a SourceName are kernel packages
45+
// which does not apply within a container, as containers use the host's kernel
46+
if p.Name() == "linux" {
47+
continue
48+
}
49+
50+
packageResults = append(packageResults, psr)
51+
}
52+
53+
if len(packageResults) != len(scanResults.PackageScanResults) {
54+
r.Infof("Filtered %d non container relevant package/s from the scan.\n", len(scanResults.PackageScanResults)-len(packageResults))
55+
}
56+
57+
scanResults.PackageScanResults = packageResults
58+
}
59+
3860
// filterIgnoredPackages removes ignore scanned packages according to config. Returns filtered scanned packages.
3961
func filterIgnoredPackages(r reporter.Reporter, scanResults *results.ScanResults) {
4062
configManager := &scanResults.ConfigManager

pkg/osvscanner/osvscanner.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,8 @@ func DoContainerScan(actions ScannerActions, r reporter.Reporter) (models.Vulner
356356
// ----- Filtering -----
357357
filterUnscannablePackages(r, &scanResult)
358358

359+
filterNonContainerRelevantPackages(r, &scanResult)
360+
359361
// --- Make Vulnerability Requests ---
360362
if accessors.VulnMatcher != nil {
361363
err = makeVulnRequestWithMatcher(r, scanResult.PackageScanResults, accessors.VulnMatcher)

0 commit comments

Comments
 (0)