Skip to content

Conversation

@cuixq
Copy link
Contributor

@cuixq cuixq commented Nov 25, 2025

Unblocks #2365

https://github.com/jedib0t/go-pretty/releases/tag/v6.7.4 introduces minor changes in the table rendering result. Snapshots are updated to reflect the changes. They are only different in styles and this should not impact GitHub annotation output.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.82%. Comparing base (33b97ed) to head (69eaf1f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2371   +/-   ##
=======================================
  Coverage   67.82%   67.82%           
=======================================
  Files         171      171           
  Lines       13018    13018           
=======================================
  Hits         8830     8830           
  Misses       3503     3503           
  Partials      685      685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cuixq cuixq marked this pull request as ready for review November 25, 2025 03:12
@cuixq cuixq requested review from G-Rath and another-rex November 25, 2025 03:12
Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean this seems ok, but it would be nice if you could comment on the actual impact of the changes i.e. I'm assuming GHA annotations still work after this, and look fine enough, but it would be great if there was a screenshot showing that

@cuixq
Copy link
Contributor Author

cuixq commented Nov 25, 2025

thanks for the feedback - I have updated the PR description.

@cuixq cuixq merged commit 6939b2a into google:main Nov 25, 2025
19 checks passed
@cuixq cuixq deleted the fix branch November 25, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants