Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsBool should handle v:true and v:false #240

Open
flwyd opened this issue Apr 23, 2021 · 1 comment
Open

IsBool should handle v:true and v:false #240

flwyd opened this issue Apr 23, 2021 · 1 comment

Comments

@flwyd
Copy link
Contributor

flwyd commented Apr 23, 2021

maktaba#ensure#IsBool(v:true) currently throws a WrongType exception because the type of v:true and v:false is boolean rather than number. It seems to me that boolean values should be handled as well.

Additionally, the absence of maktaba#value#IsBool seems like a notable omission.

@dbarnett
Copy link
Contributor

Fair point, might as well accommodate those (and then bump maktaba's version so you could reliably depend on it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants