Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect neovim vs. vim automatically #132

Open
dbarnett opened this issue Aug 28, 2024 · 3 comments
Open

Detect neovim vs. vim automatically #132

dbarnett opened this issue Aug 28, 2024 · 3 comments

Comments

@dbarnett
Copy link
Contributor

Currently if you run vroom it tries to invoke vim classic as 'vim', or if you pass the --neovim option it tries to invoke neovim as 'nvim'. This gets annoying in a few ways:

  • It gets very confused for users who alias vim to neovim on their systems
  • It gives you no way to override the vim/nvim command to run
  • In error scenarios it gives really cryptic error output since it can't infer any context about how the target vim instance is supposed to work

It would be nice to generalize that and add inference so that you have more control over which vim executable it's invoking and it can more automagically figure out which options to pass to whichever vim variant it's pointed at.

@dbarnett
Copy link
Contributor Author

FYI I have the improvements for this implemented in https://github.com/dbarnett/vroom/tree/detect_vim, but they're stacked on top of #133 so I'll wait to send a PR until that one's merged.

@snu5mumr1k
Copy link
Contributor

I would like to re-word this issue. Something like 'Allow configuration of the path to vim/nvim executable'. And as part of what needs to be done improve on the errors quality.

The root cause for it is not that we don't do things automatically, but that we use a command name instead of a file and don't allow the overwrite.

For a testing framework making automatic choices is arguably less than desirable, as the mistake in configuration may survive unnoticed.

A side note: I don't think aliases matter as much, because we don't use bash, but symlink collisions in path are very much an obvious problem.

@dbarnett
Copy link
Contributor Author

That name SGTM. LMK if anything beyond the title sounds bad to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants