Merge pull request #42 from keith/ks/fix-productmodulename-with-dashes

Fix ProductModuleName with dashes
google · Mar 18, 2022 · e0bc4b2 · e0bc4b2
2 parents db0fce1 + b7585ca
commit e0bc4b2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/test_runner/xctestrun.py b/test_runner/xctestrun.py
@@ -499,7 +499,7 @@ def _GenerateTestRootForXcuitest(self):
         'DYLD_LIBRARY_PATH': '__TESTROOT__:%s/usr/lib' % developer_path
     }
     self._xctestrun_dict = {
-        'ProductModuleName': self._test_name,
+        'ProductModuleName': self._test_name.replace("-", "_"),
         'IsUITestBundle': True,
         'SystemAttachmentLifetime': 'keepNever',
         'TestBundlePath': self._test_bundle_dir,
@@ -666,7 +666,7 @@ def _GenerateTestRootForXctest(self):
         'DYLD_LIBRARY_PATH': '__TESTROOT__:%s/usr/lib:' % developer_path
     }
     self._xctestrun_dict = {
-        'ProductModuleName': self._test_name,
+        'ProductModuleName': self._test_name.replace("-", "_"),
         'TestHostPath': self._app_under_test_dir,
         'TestBundlePath': self._test_bundle_dir,
         'IsAppHostedTestBundle': True,
@@ -687,7 +687,7 @@ def _GenerateTestRootForLogicTest(self):
         'DYLD_LIBRARY_PATH': dyld_framework_path
     }
     self._xctestrun_dict = {
-        'ProductModuleName': self._test_name,
+        'ProductModuleName': self._test_name.replace("-", "_"),
         'TestBundlePath': self._test_bundle_dir,
         'TestHostPath': xcode_info_util.GetXctestToolPath(self._sdk),
         'TestingEnvironmentVariables': test_envs,