Skip to content

Commit ec8b46e

Browse files
hzellercopybara-github
authored andcommitted
Fix a couple of mismatching argument comments.
PiperOrigin-RevId: 721529013
1 parent fdc91a4 commit ec8b46e

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

xls/codegen/proc_block_conversion.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ static absl::StatusOr<std::vector<Node*>> MakeValidNodesForInputStates(
486486
Node * state_valid,
487487
NaryOrIfNeeded(block, state_valid_conditions,
488488
/*name=*/state_valid_name,
489-
/*loc=*/state_register->reg_full_read->loc()));
489+
/*source_info=*/state_register->reg_full_read->loc()));
490490
active_valids.push_back(state_valid);
491491
}
492492

xls/dslx/bytecode/bytecode_interpreter_test.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ static absl::StatusOr<InterpValue> Interpret(
120120
XLS_RET_CHECK_EQ(bf->owner(), f->owner());
121121

122122
return BytecodeInterpreter::Interpret(import_data, bf.get(), args,
123-
/*hierarchy_interpreter=*/std::nullopt,
123+
/*channel_manager=*/std::nullopt,
124124
options);
125125
}
126126

@@ -138,10 +138,10 @@ TEST_F(BytecodeInterpreterTest, DupLiteral) {
138138
/*type_info=*/nullptr, std::move(bytecodes)));
139139
BytecodeInterpreterOptions options;
140140
options.set_validate_final_stack_depth(false);
141-
XLS_ASSERT_OK_AND_ASSIGN(
142-
InterpValue result, BytecodeInterpreter::Interpret(
143-
&import_data_.value(), bfunc.get(), {},
144-
/*hierarchy_interpreter=*/std::nullopt, options));
141+
XLS_ASSERT_OK_AND_ASSIGN(InterpValue result,
142+
BytecodeInterpreter::Interpret(
143+
&import_data_.value(), bfunc.get(), {},
144+
/*channel_manager=*/std::nullopt, options));
145145
EXPECT_EQ(result.ToString(), "u32:42");
146146
}
147147

xls/dslx/frontend/ast_utils.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ static std::optional<bool> TryEvaluateAsBool(const Expr* expr) {
316316
GetSignAndMagnitude(number->text());
317317
if (sm.ok() && sm->second.bit_count() <= 1) {
318318
// Note: the zero value is given as a bit count of zero.
319-
bool value = sm->second.bit_count() == 0 ? 0 : sm->second.Get(0);
319+
bool value = sm->second.bit_count() == 0 ? false : sm->second.Get(0);
320320
return std::optional<bool>(value);
321321
}
322322
}

xls/dslx/interp_value_utils_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,8 @@ TEST(InterpValueHelpersTest, ValueToInterpValue) {
270270

271271
TEST(InterpValueHelpersTest, ValueToInterpValueEnum) {
272272
EnumDef enum_def(/*owner=*/nullptr, /*span=*/Span::Fake(),
273-
/*name_def=*/nullptr, /*parametric_bindings=*/{},
274-
/*members=*/{}, /*is_public=*/false);
273+
/*name_def=*/nullptr, /*type=*/{},
274+
/*values=*/{}, /*is_public=*/false);
275275
EnumType enum_type(enum_def, TypeDim::CreateU32(32), /*is_signed=*/false, {});
276276
EXPECT_THAT(ValueToInterpValue(Value(UBits(3, 32)), &enum_type),
277277
IsOkAndHolds(Eq(InterpValue::MakeEnum(

xls/dslx/run_routines/run_routines.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ absl::Status RunDslxTestFunction(ImportData* import_data, TypeInfo* type_info,
146146
BytecodeEmitterOptions{.format_preference =
147147
options.format_preference()}));
148148
return BytecodeInterpreter::Interpret(import_data, bf.get(), /*args=*/{},
149-
/*hierarchy_interpreter=*/std::nullopt,
149+
/*channel_manager=*/std::nullopt,
150150
options)
151151
.status();
152152
}

xls/ir/package_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ TEST_F(PackageTest, CreateStreamingChannel) {
333333
Channel * ch42,
334334
p.CreateStreamingChannel(
335335
"ch42", ChannelOps::kReceiveOnly, p.GetBitsType(44),
336-
/*initial_values=*/{}, /*channel_config=*/std::nullopt,
336+
/*initial_values=*/{}, /*fifo_config=*/std::nullopt,
337337
FlowControl::kReadyValid, ChannelStrictness::kProvenMutuallyExclusive,
338338
ChannelMetadataProto(), 42));
339339
EXPECT_EQ(ch42->id(), 42);
@@ -348,7 +348,7 @@ TEST_F(PackageTest, CreateStreamingChannel) {
348348
// Creating a channel with a duplicate ID is an error.
349349
EXPECT_THAT(p.CreateStreamingChannel(
350350
"ch1_dup", ChannelOps::kReceiveOnly, p.GetBitsType(44),
351-
/*initial_values=*/{}, /*channel_config=*/std::nullopt,
351+
/*initial_values=*/{}, /*fifo_config=*/std::nullopt,
352352
FlowControl::kReadyValid,
353353
ChannelStrictness::kProvenMutuallyExclusive,
354354
ChannelMetadataProto(), 1)

xls/passes/conditional_specialization_pass_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1219,7 +1219,7 @@ TEST_F(ConditionalSpecializationPassTest, StateReadSpecialization) {
12191219
BValue counter0 = pb.StateElement("counter0", UBits(0, 32));
12201220
BValue counter1 = pb.StateElement("counter1", UBits(5, 32));
12211221
BValue selected_counter =
1222-
pb.Select(index_is_1, {counter1}, /*default_value=*/counter0);
1222+
pb.Select(index_is_1, {counter1}, /*on_false=*/counter0);
12231223
BValue incremented_counter =
12241224
pb.Add(selected_counter, pb.Literal(UBits(1, 32)));
12251225
pb.Next(index, index_is_0);
@@ -1252,7 +1252,7 @@ TEST_F(ConditionalSpecializationPassTest, StateReadSpecializationDisabled) {
12521252
BValue counter0 = pb.StateElement("counter0", UBits(0, 32));
12531253
BValue counter1 = pb.StateElement("counter1", UBits(5, 32));
12541254
BValue selected_counter =
1255-
pb.Select(index_is_1, {counter1}, /*default_value=*/counter0);
1255+
pb.Select(index_is_1, {counter1}, /*on_false=*/counter0);
12561256
BValue incremented_counter =
12571257
pb.Add(selected_counter, pb.Literal(UBits(1, 32)));
12581258
pb.Next(index, index_is_0);

0 commit comments

Comments
 (0)