Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests that pass in the DSLX interpreter, fail with deadline in the IR interpreter #1898

Open
rw1nkler opened this issue Jan 30, 2025 · 0 comments

Comments

@rw1nkler
Copy link
Contributor

Describe the bug

We noticed that some of the procs from the ZSTD Decoder cannot be correctly translated to the IR. In a few cases the same simulation that works with the DSLX interpreter, hangs when run with the IR interpreter.

This is a case for at least two tests:

  • RamDemux3Test (rule)
  • ZstdDecoderInternalTest (rule)

To Reproduce

Steps to reproduce the behavior:

  1. Checkout to the zstd_ir_problem branch
  2. Run bazel run //xls/modules/zstd:ram_demux3_dslx_test to run the test with the IR interpreter
  3. Observe the following error:
Executing tests from //xls/modules/zstd:ram_demux3_dslx_test
-----------------------------------------------------------------------------
[ RUN UNITTEST  ] RamDemux3Test
qE0130 14:34:39.920672 1784807 run_routines.cc:110] Internal error: DEADLINE_EXCEEDED: Exceeded limit of 100000 ticks of the proc network before expected output produced
[        FAILED ] RamDemux3Test: internal error: DEADLINE_EXCEEDED: Exceeded limit of 100000 ticks of the proc network before expected output produced
  1. Open the BUILD file and remove the evaluator="ir-interpreter" option from the ram_demux3_dslx_test rule.
  2. Run the test with DSLX interpreter and see the test passing

Expected behavior

The test should give the same result when run with DSLX and IR interpreters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant