Skip to content

Commit fc3eeaa

Browse files
sofislgcf-owl-bot[bot]d-goog
authored
chore!: migrate gax to Node 18 (#1699)
* chore!: migrate gax to Node 18 * cleanup * chore: upgrade to node 18 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * migrate to node 18 * downgrade dep * update package.json * downgrade dep * chore: update to node-feth v3 and fix typings issues * downgrade execa * try to make node-fetch v3 work * update node version * update regapic * chore: update regapic imports * reconfigure mocking * chore: use node-fetch v3 * Update CODEOWNERS * Update release-trigger.yml * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * attempt to get browser tests working * add json file to tsconfig * retry * retry * retry * retry * more ts changes * retry * retry * retry loading node fetch * reattempt to lalow dynamic import * revert node-fetch * readd json files * readd json files * downgrade types/node * retry * retry browser test * PR cleanup; * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update .OwlBot.lock.yaml * Update .OwlBot.lock.yaml * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert change to tsconfig * remove node 12 configs * fix: upgrade webpack to v5 to match the new typescript version * run lint * attempt to fix linting problem * remove floating promises TS error for tests * add @ sign to disable linting * chore: migrate tools to node 18 as well * downgrade walkup * run lint * fix lint * attempt to upgrade node-fetch to v3 * run lint * readd abort controller * readd abort controller in test * run lint * run lint * fix tests * fix tests * run lint * upgradependencies --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: d-goog <[email protected]>
1 parent 27c52a0 commit fc3eeaa

File tree

104 files changed

+1842
-1863
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

104 files changed

+1842
-1863
lines changed

‎.github/sync-repo-settings.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ branchProtectionRules:
1111
- docs
1212
- lint-gax
1313
- lint-tools
14-
- test-gax (14)
14+
- test-gax (18)
1515
- test-gax (16)
16-
- test-tools (14)
16+
- test-tools (18)
1717
- test-tools (16)
1818
- cla/google
1919
- windows-gax

‎.github/workflows/ci.yaml

+11-11
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: ubuntu-latest
1010
strategy:
1111
matrix:
12-
node: [14, 16]
12+
node: [18, 20]
1313
steps:
1414
- uses: actions/checkout@v4
1515
- uses: actions/setup-node@v4
@@ -30,7 +30,7 @@ jobs:
3030
runs-on: ubuntu-latest
3131
strategy:
3232
matrix:
33-
node: [14, 16]
33+
node: [18, 16]
3434
steps:
3535
- uses: actions/checkout@v4
3636
- uses: actions/setup-node@v4
@@ -51,7 +51,7 @@ jobs:
5151
runs-on: ubuntu-latest
5252
strategy:
5353
matrix:
54-
node: [14, 16]
54+
node: [18, 20]
5555
steps:
5656
- uses: actions/checkout@v4
5757
- uses: actions/setup-node@v4
@@ -72,7 +72,7 @@ jobs:
7272
runs-on: ubuntu-latest
7373
strategy:
7474
matrix:
75-
node: [14, 16]
75+
node: [18, 20]
7676
steps:
7777
- uses: actions/checkout@v4
7878
- uses: actions/setup-node@v4
@@ -95,7 +95,7 @@ jobs:
9595
- uses: actions/checkout@v4
9696
- uses: actions/setup-node@v4
9797
with:
98-
node-version: 14
98+
node-version: 18
9999
- run: cd gax; npm install
100100
- run: cd gax; npm test
101101
env:
@@ -106,7 +106,7 @@ jobs:
106106
- uses: actions/checkout@v4
107107
- uses: actions/setup-node@v4
108108
with:
109-
node-version: 14
109+
node-version: 18
110110
- run: cd tools; npm install
111111
- run: cd tools; npm test
112112
env:
@@ -117,7 +117,7 @@ jobs:
117117
- uses: actions/checkout@v4
118118
- uses: actions/setup-node@v4
119119
with:
120-
node-version: 14
120+
node-version: 18
121121
- run: cd logging-utils; npm install
122122
- run: cd logging-utils; npm test
123123
env:
@@ -128,7 +128,7 @@ jobs:
128128
- uses: actions/checkout@v4
129129
- uses: actions/setup-node@v4
130130
with:
131-
node-version: 14
131+
node-version: 18
132132
- run: cd gax; npm install
133133
- run: cd gax; npm run lint
134134
lint-tools:
@@ -137,7 +137,7 @@ jobs:
137137
- uses: actions/checkout@v4
138138
- uses: actions/setup-node@v4
139139
with:
140-
node-version: 14
140+
node-version: 18
141141
- run: cd tools; npm install
142142
- run: cd tools; npm run lint
143143
lint-logging-utils:
@@ -146,7 +146,7 @@ jobs:
146146
- uses: actions/checkout@v4
147147
- uses: actions/setup-node@v4
148148
with:
149-
node-version: 14
149+
node-version: 18
150150
- run: cd logging-utils; npm install
151151
- run: cd logging-utils; npm run lint
152152
docs:
@@ -155,7 +155,7 @@ jobs:
155155
- uses: actions/checkout@v4
156156
- uses: actions/setup-node@v4
157157
with:
158-
node-version: 14
158+
node-version: 18
159159
- run: cd gax; npm install
160160
- run: cd gax; npm run docs
161161
- uses: JustinBeckwith/linkinator-action@v1

‎.kokoro/common.cfg

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/continuous/node14/common.cfg

-24
This file was deleted.

‎.kokoro/continuous/node14/lint.cfg

-4
This file was deleted.

‎.kokoro/continuous/node14/samples-test.cfg

-12
This file was deleted.

‎.kokoro/continuous/node14/system-test.cfg

-12
This file was deleted.

‎.kokoro/continuous/node14/test.cfg

Whitespace-only changes.

‎.kokoro/presubmit/node14/common.cfg

-24
This file was deleted.

‎.kokoro/presubmit/node14/samples-test.cfg

-12
This file was deleted.

‎.kokoro/presubmit/node14/system-test.cfg

-12
This file was deleted.

‎.kokoro/presubmit/node14/test.cfg

Whitespace-only changes.

‎.kokoro/release/docs.cfg

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/release/publish.cfg

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/samples-test.sh

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/system-test.sh

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/test.bat

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/test.sh

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎gax/.eslintignore

+4
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,7 @@ build/
55
docs/
66
protos/
77
samples/generated/
8+
test/browser-test/
9+
test/showcase-echo-client/src/
10+
test/showcase-server/
11+
test/test-application/src/

0 commit comments

Comments
 (0)