Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance impact of calling JSON.stringify in loadProtoJSON #1690

Open
mattzeunert opened this issue Dec 30, 2024 · 0 comments
Open

Performance impact of calling JSON.stringify in loadProtoJSON #1690

mattzeunert opened this issue Dec 30, 2024 · 0 comments
Labels
size: l Pull request size is large. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mattzeunert
Copy link

We're using the compute engine InstancesClient and notice that every time we create an instance of it we spend a bunch of time in JSON.stringify as it's generating a 1.4 MB object. (This is running in a .333 vCPU cloud function.)

This is the call stack:

at GrpcClient.loadProtoJSON (/workspace/node_modules/google-gax/build/src/fallback.js:117:38)
at new InstancesClient (/workspace/node_modules/@google-cloud/compute/build/src/v1/instances_client.js:149:38)

Maybe that can be optimized somehow?

Screenshot 2024-12-30 at 09 15 39
@sofisl sofisl added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. size: l Pull request size is large. labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
size: l Pull request size is large. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattzeunert @sofisl