Skip to content

Commit 609c2d2

Browse files
committed
fix: more potential merging issues
1 parent 690ee5f commit 609c2d2

5 files changed

+7
-9
lines changed

src/auth/defaultawssecuritycredentialssupplier.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ export class DefaultAwsSecurityCredentialsSupplier
194194
*/
195195
async #getImdsV2SessionToken(transporter: Gaxios): Promise<string> {
196196
const request = {
197-
...this.additionalGaxiosOptions,
198197
url: this.imdsV2SessionTokenUrl,
199198
method: 'PUT',
200199
headers: {'x-aws-ec2-metadata-token-ttl-seconds': '300'},
@@ -261,8 +260,8 @@ export class DefaultAwsSecurityCredentialsSupplier
261260
};
262261
this.log.info('#retrieveAwsSecurityCredentials %j', request);
263262
const response = await transporter.request<AwsSecurityCredentialsResponse>({
264-
...request,
265263
...this.additionalGaxiosOptions,
264+
...request,
266265
});
267266
this.log.info('#retrieveAwsSecurityCredentials %s', response.data);
268267
return response.data;

src/auth/oauth2client.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -758,9 +758,9 @@ export class OAuth2Client extends AuthClient {
758758
this.log.info('getTokenAsync %j', request);
759759

760760
const res = await this.transporter.request<CredentialRequest>({
761-
...request,
762761
...OAuth2Client.RETRY_CONFIG,
763762
method: 'POST',
763+
...request,
764764
});
765765
const tokens = res.data as Credentials;
766766
this.log.info('getTokenAsync success %j', tokens);
@@ -828,9 +828,9 @@ export class OAuth2Client extends AuthClient {
828828
try {
829829
// request for new token
830830
res = await this.transporter.request<CredentialRequest>({
831-
...request,
832831
...OAuth2Client.RETRY_CONFIG,
833832
method: 'POST',
833+
...request,
834834
});
835835
} catch (exc) {
836836
const e = exc as Error;
@@ -1065,7 +1065,7 @@ export class OAuth2Client extends AuthClient {
10651065
}, callback);
10661066
} else {
10671067
return this.transporter.request<RevokeCredentialsResult>(opts).then(r => {
1068-
this.log.info('revokeToken success %j', r.data);
1068+
this.log.info('revokeToken success %s', r.data ?? '');
10691069
return r;
10701070
});
10711071
}

src/auth/refreshclient.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ export class UserRefreshClient extends OAuth2Client {
102102
async fetchIdToken(targetAudience: string): Promise<string> {
103103
const request = {
104104
url: this.endpoints.oauth2TokenUrl,
105-
method: 'POST',
106105
data: new URLSearchParams({
107106
client_id: this._clientId,
108107
client_secret: this._clientSecret,
@@ -114,9 +113,9 @@ export class UserRefreshClient extends OAuth2Client {
114113
this.log.info('fetchIdToken %j', request);
115114

116115
const res = await this.transporter.request<CredentialRequest>({
117-
...request,
118116
...UserRefreshClient.RETRY_CONFIG,
119117
method: 'POST',
118+
...request,
120119
});
121120

122121
this.log.info('fetchIdToken success %s', res?.data?.id_token);

src/auth/stscredentials.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -220,9 +220,9 @@ export class StsCredentials extends OAuthClientAuthHandler {
220220
this.log.info('exchangeToken %j', request);
221221

222222
const opts: GaxiosOptions = {
223-
...request,
224223
...StsCredentials.RETRY_CONFIG,
225224
method: 'POST',
225+
...request,
226226
};
227227
// Apply OAuth client authentication.
228228
this.applyClientAuthenticationOptions(opts);

src/auth/urlsubjecttokensupplier.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ export class UrlSubjectTokenSupplier implements SubjectTokenSupplier {
9191
this.log.info('getSubjectToken %j', request);
9292

9393
const opts: GaxiosOptions = {
94-
...request,
9594
...this.additionalGaxiosOptions,
9695
method: 'GET',
96+
...request,
9797
};
9898
let subjectToken: string | undefined;
9999
if (this.formatType === 'text') {

0 commit comments

Comments
 (0)