-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Config
with configuration components
#700
Comments
I think these components would also allow for another service called Then the current subcommands would essentially just be the CLI representations of these components. This would also be a better place for the relay client than the control plane, as it means we don't also expose aDS server, and you could replicate the same functionality of having both with the Example
|
100% yes to having different The nice thing about this, is you can still have a singular config file (and we could allow multiple The internal config object could then become a Map[Kind]/Vec of each of these Config types -- which would still also allow for Also solves my problem in #63 If we want to go with a more "Kubernetes" resource style model that people are familiar with, we should probably use |
Currently we have the concept of a single "monolith" config file that's shared between all services from when there was only a proxy service. In its current form I don't find it to always to be clear when something is being shared and when something isn't, so I'd like to propose that we move away from the current configuration and instead create configuration files for specific components in Quilkin, this will make it easier to isolate and share specific parts of configuration without accidentally overriding another part of configuration, which also enables us to potentially have multiple configuration providers for different components to be running at once. It will also allow for the configuration to diverge from the schema of the current
Config
to be potentially more user-friendly.A couple examples of component configuration that I think we should start with, namely ones for each service, and for
FilterChain
configuration. To be able to share code and make the configuration of each component more unified, I think we should adopt the same schema as Kubernetes CRDs, this would allow us to reuse more code for parsing, it's a format that people are already familiar with, and it allows for these components to potentially become CRD's down the line that can be discovered using a kubernetes configuration provider.The text was updated successfully, but these errors were encountered: