-
Notifications
You must be signed in to change notification settings - Fork 174
/
Copy pathAnnotateVersionCheck.md.html
157 lines (131 loc) · 5 KB
/
AnnotateVersionCheck.md.html
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
<meta charset="utf-8">
(#) Annotate SDK_INT checks
!!! WARNING: Annotate SDK_INT checks
This is a warning.
Id
: `AnnotateVersionCheck`
Summary
: Annotate SDK_INT checks
Severity
: Warning
Category
: Correctness
Platform
: Android
Vendor
: Android Open Source Project
Feedback
: https://issuetracker.google.com/issues/new?component=192708
Since
: 7.0.0 (July 2021)
Affects
: Kotlin and Java files
Editing
: This check runs on the fly in the IDE editor
Implementation
: [Source Code](https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-checks/src/main/java/com/android/tools/lint/checks/SdkIntDetector.kt)
Tests
: [Source Code](https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-tests/src/test/java/com/android/tools/lint/checks/SdkIntDetectorTest.kt)
Methods which perform `SDK_INT` version checks (or field constants which
reflect the result of a version check) in libraries should be annotated
with `@ChecksSdkIntAtLeast`. This makes it possible for lint to
correctly check calls into the library later to correctly understand
that problematic code which is wrapped within a call into this library
is safe after all.
!!! Tip
This lint check has an associated quickfix available in the IDE.
(##) Example
Here is an example of lint warnings produced by this check:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~text
src/test/pkg/test.kt:8:Warning: This method should be annotated with
@ChecksSdkIntAtLeast(api=VERSION_CODES.N) [AnnotateVersionCheck]
fun isNougat(): Boolean {
--------
src/test/pkg/test.kt:12:Warning: This method should be annotated with
@ChecksSdkIntAtLeast(parameter=0) [AnnotateVersionCheck]
fun isAtLeast(api: Int): Boolean {
---------
src/test/pkg/test.kt:16:Warning: This method should be annotated with
@ChecksSdkIntAtLeast(api=Build.VERSION_CODES.O, lambda=1)
[AnnotateVersionCheck]
inline fun <T> T.applyForOreoOrAbove(block: T.() -> Unit): T {
-------------------
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Here is the source file referenced above:
`src/test/pkg/test.kt`:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~kotlin linenumbers
package test.pkg
import android.os.Build
import android.os.Build.VERSION
import android.os.Build.VERSION.SDK_INT
import android.os.Build.VERSION_CODES
fun isNougat(): Boolean {
return VERSION.SDK_INT >= VERSION_CODES.N
}
fun isAtLeast(api: Int): Boolean {
return VERSION.SDK_INT >= api
}
inline fun <T> T.applyForOreoOrAbove(block: T.() -> Unit): T {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
block()
}
return this
}
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
You can also visit the
[source code](https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-tests/src/test/java/com/android/tools/lint/checks/SdkIntDetectorTest.kt)
for the unit tests for this check to see additional scenarios.
(##) Suppressing
You can suppress false positives using one of the following mechanisms:
* Using a suppression annotation like this on the enclosing
element:
```kt
// Kotlin
@Suppress("AnnotateVersionCheck")
fun method() {
getBuildSdkInt(...)
}
```
or
```java
// Java
@SuppressWarnings("AnnotateVersionCheck")
void method() {
getBuildSdkInt(...);
}
```
* Using a suppression comment like this on the line above:
```kt
//noinspection AnnotateVersionCheck
problematicStatement()
```
* Using a special `lint.xml` file in the source tree which turns off
the check in that folder and any sub folder. A simple file might look
like this:
```xml
<?xml version="1.0" encoding="UTF-8"?>
<lint>
<issue id="AnnotateVersionCheck" severity="ignore" />
</lint>
```
Instead of `ignore` you can also change the severity here, for
example from `error` to `warning`. You can find additional
documentation on how to filter issues by path, regular expression and
so on
[here](https://googlesamples.github.io/android-custom-lint-rules/usage/lintxml.md.html).
* In Gradle projects, using the DSL syntax to configure lint. For
example, you can use something like
```gradle
lintOptions {
disable 'AnnotateVersionCheck'
}
```
In Android projects this should be nested inside an `android { }`
block.
* For manual invocations of `lint`, using the `--ignore` flag:
```
$ lint --ignore AnnotateVersionCheck ...`
```
* Last, but not least, using baselines, as discussed
[here](https://googlesamples.github.io/android-custom-lint-rules/usage/baselines.md.html).
<!-- Markdeep: --><style class="fallback">body{visibility:hidden;white-space:pre;font-family:monospace}</style><script src="markdeep.min.js" charset="utf-8"></script><script src="https://morgan3d.github.io/markdeep/latest/markdeep.min.js" charset="utf-8"></script><script>window.alreadyProcessedMarkdeep||(document.body.style.visibility="visible")</script>