Added JSHint linting to the gulp file and fixed errors and warnings.

Author: Eric Koleda

gulpfile.js

@@ -6,6 +6,8 @@ var gulpif = require('gulp-if');
 var del = require('del');
 var bump = require('gulp-bump');
 var rename = require("gulp-rename");
+var jshint = require('gulp-jshint');
+var stylish = require('jshint-stylish');
 
 gulp.task('release', ['clean', 'dist'], function() {
   gulp.src('./package.json')
@@ -30,3 +32,9 @@ gulp.task('clean', function() {
     'dist/*'
   ]);
 });
+
+gulp.task('lint', function() {
+  return gulp.src('src/*.gs')
+    .pipe(jshint())
+    .pipe(jshint.reporter(stylish));
+});

package.json

@@ -20,8 +20,10 @@
     "gulp-concat": "^2.6.0",
     "gulp-expose": "0.0.7",
     "gulp-if": "^1.2.5",
+    "gulp-jshint": "^1.12.0",
     "gulp-rename": "^1.2.2",
-    "gulp-strip-line": "0.0.1"
+    "gulp-strip-line": "0.0.1",
+    "jshint-stylish": "^2.0.1"
   },
   "dependencies": {
     "underscore": "^1.8.3"

src/OAuth2.gs

@@ -56,5 +56,5 @@ if (module) {
   module.exports = {
     createService: createService,
     getRedirectUri: getRedirectUri
-  }
+  };
 }

src/Service.gs

@@ -16,6 +16,10 @@
  * @fileoverview Contains the Service_ class.
  */
 
+// Disable JSHint warnings for the use of eval(), since it's required to prevent
+// scope issues in Apps Script.
+// jshint evil:true
+
 /**
  * Creates a new OAuth2 service.
  * @param {string} serviceName The name of the service.
@@ -170,7 +174,7 @@ Service_.prototype.setCache = function(cache) {
  */
 Service_.prototype.setScope = function(scope, opt_separator) {
   var separator = opt_separator || ' ';
-  this.params_['scope'] = _.isArray(scope) ? scope.join(separator) : scope;
+  this.params_.scope = _.isArray(scope) ? scope.join(separator) : scope;
   return this;
 };
 
@@ -574,10 +578,10 @@ Service_.prototype.createJwt_ = function() {
     iat: Math.round(now.getTime() / 1000)
   };
   if (this.subject_) {
-    claimSet['sub'] = this.subject_;
+    claimSet.sub = this.subject_;
   }
-  if (this.params_['scope']) {
-   claimSet['scope'] =  this.params_['scope'];
+  if (this.params_.scope) {
+   claimSet.scope =  this.params_.scope;
   }
   var toSign = Utilities.base64EncodeWebSafe(JSON.stringify(header)) + '.' + Utilities.base64EncodeWebSafe(JSON.stringify(claimSet));
   var signatureBytes = Utilities.computeRsaSha256Signature(toSign, this.privateKey_);

src/Utilities.gs

@@ -53,7 +53,7 @@ function validate_(params) {
  * @private
  */
 function isEmpty_(value) {
-  return value == null || value == undefined ||
+  return value === null || value === undefined ||
       ((_.isObject(value) || _.isString(value)) && _.isEmpty(value));
 }