Skip to content

Commit 0a59532

Browse files
committed
fix: events and types
1 parent e532706 commit 0a59532

File tree

4 files changed

+18
-9
lines changed

4 files changed

+18
-9
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,10 @@ Note: The Google Picker API does not support file organization, moving, or copyi
100100

101101
### Methods
102102

103-
| Method | Type |
104-
| --------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- |
105-
| `addEventListener` | `(type: "cancel" \| "picked", listener: (ev: CustomEvent<ResponseObject>): void, options?: boolean \| AddEventListenerOptions \| undefined) => void` |
106-
| `removeEventListener` | `(type: "cancel" \| "picked", listener: (ev: CustomEvent<ResponseObject>): void, options?: boolean \| EventListenerOptions \| undefined) => void` |
103+
| Method | Type |
104+
| --------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------- |
105+
| `addEventListener` | `(type: "cancel" \| "picked" \| "loaded", listener: (ev: DrivePickerEvent): void, options?: boolean \| AddEventListenerOptions \| undefined) => void` |
106+
| `removeEventListener` | `(type: "cancel" \| "picked" \| "loaded", listener: (ev: DrivePickerEvent): void, options?: boolean \| EventListenerOptions \| undefined) => void` |
107107

108108
### Events
109109

src/drive-picker/drive-picker-element.ts

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,19 @@ export interface DrivePickerElementProps {
4444
width?: number;
4545
}
4646

47+
export type DrivePickerEvent = CustomEvent<google.picker.ResponseObject>;
48+
49+
// TODO fix typings for Action to include "loaded"
50+
4751
export interface DrivePickerElementEventListeners {
4852
addEventListener(
49-
type: "cancel" | "picked",
50-
listener: (ev: CustomEvent<google.picker.ResponseObject>) => void,
53+
type: "cancel" | "picked" | "loaded",
54+
listener: (ev: DrivePickerEvent) => void,
5155
options?: boolean | AddEventListenerOptions,
5256
): void;
5357
removeEventListener(
54-
type: "cancel" | "picked",
55-
listener: (ev: CustomEvent<google.picker.ResponseObject>) => void,
58+
type: "cancel" | "picked" | "loaded",
59+
listener: (ev: DrivePickerEvent) => void,
5660
options?: boolean | EventListenerOptions,
5761
): void;
5862
}
@@ -275,6 +279,10 @@ export class DrivePickerElement
275279

276280
private callbackToDispatchEvent(data: google.picker.ResponseObject) {
277281
this.visible = Boolean(this.picker?.isVisible());
282+
// TODO file bug for this
283+
if (data.action === google.picker.Action.CANCEL) {
284+
this.visible = false;
285+
}
278286
this.dispatch(data.action, data);
279287
}
280288

src/drive-picker/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
export {
1818
DrivePickerElement,
19+
type DrivePickerEvent,
1920
type DrivePickerElementProps,
2021
} from "./drive-picker-element";
2122

src/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export async function retrieveAccessToken(
3636
}
3737

3838
return new Promise((resolve) => {
39-
const client = google.accounts.oauth2.initTokenClient({
39+
const client = window.google.accounts.oauth2.initTokenClient({
4040
client_id: clientId,
4141
scope,
4242

0 commit comments

Comments
 (0)