JWT plugin config parsing

Author: romanoff

plugins/jwt/jwt.go

@@ -1,18 +1,37 @@
 package jwt
 
 import (
+	"errors"
+	"fmt"
+	"github.com/BurntSushi/toml"
+	"io/ioutil"
 	"time"
 )
 
+type duration struct {
+	time.Duration
+}
+
+func (d *duration) UnmarshalText(text []byte) error {
+	var err error
+	d.Duration, err = time.ParseDuration(string(text))
+	return err
+}
+
 type JWT struct {
-	Secret           []byte
+	Secret           string
 	Issuer           string
-	ExpirationTime   time.Time
-	RotationDeadline time.Time
+	ExpirationTime   duration `toml:"expiration"`
+	RotationDeadline duration `toml:"rotation_deadline"`
 }
 
 func (self *JWT) ParseConfig(path string) error {
-	return nil
+	content, err := ioutil.ReadFile(path)
+	if err != nil {
+		return errors.New(fmt.Sprintf("Error while reading plugin config: %v", err))
+	}
+	_, err = toml.Decode(string(content), self)
+	return err
 }
 
 // app.Register(&JWT{}, "jwt") || app.Register("jwt", JWT)

plugins/jwt/jwt_test.go

@@ -2,6 +2,7 @@ package jwt
 
 import (
 	"testing"
+	"time"
 )
 
 func TestParseConfig(t *testing.T) {
@@ -10,7 +11,16 @@ func TestParseConfig(t *testing.T) {
 	if err != nil {
 		t.Error(err)
 	}
-	if string(jwtPlugin.Secret) != "secret123" {
-		t.Errorf("Secret key was parsed incorrectly. Expected: '%v', but got: '%v'", "secret123", string(jwtPlugin.Secret))
+	if jwtPlugin.Secret != "secret123" {
+		t.Errorf("Secret attribute was parsed incorrectly. Expected: '%v', but got: '%v'", "secret123", jwtPlugin.Secret)
+	}
+	if jwtPlugin.Issuer != "issuer" {
+		t.Errorf("Issuer attribute was parsed incorrectly. Expected: '%v', but got: '%v'", "issuer", jwtPlugin.Issuer)
+	}
+	if jwtPlugin.ExpirationTime.Duration != time.Duration(time.Hour*4) {
+		t.Errorf("Expected 4 hour expiratio time, but got: %v", jwtPlugin.ExpirationTime.Duration)
+	}
+	if jwtPlugin.RotationDeadline.Duration != time.Duration(time.Hour*2) {
+		t.Errorf("Expected 2 hour rotation deadline, but got: %v", jwtPlugin.RotationDeadline.Duration)
 	}
 }