Skip to content

Commit a68403b

Browse files
committed
chardev: report a simpler error about duplicated id
Report: "Chardev with id 'char2' already exists" Rather than: "Failed to add chardev 'char2': duplicate yank instance" Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Daniel P. Berrangé <[email protected]>
1 parent 64195b0 commit a68403b

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

chardev/char.c

+5
Original file line numberDiff line numberDiff line change
@@ -1036,6 +1036,11 @@ ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,
10361036
ChardevReturn *ret;
10371037
g_autoptr(Chardev) chr = NULL;
10381038

1039+
if (qemu_chr_find(id)) {
1040+
error_setg(errp, "Chardev with id '%s' already exists", id);
1041+
return NULL;
1042+
}
1043+
10391044
cc = char_get_class(ChardevBackendKind_str(backend->type), errp);
10401045
if (!cc) {
10411046
goto err;

0 commit comments

Comments
 (0)