Skip to content

Commit cd81a69

Browse files
author
Muhammad Luthfi Fahlevi
committed
feat(docs): add comments in QueryExprTranslator
1 parent 17918ce commit cd81a69

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

pkg/translator/query_expr_translator.go

+4
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ func (q *QueryExprTranslator) ConvertToSQL() (string, error) {
3535
return q.SqlQuery.String(), nil
3636
}
3737

38+
// TranslateToSQL The idea came from ast.Walk. Currently, the development focus implement for the node type that most likely used in our needs.
39+
// TODO: implement translator for node type that still not covered right now.
3840
func (q *QueryExprTranslator) TranslateToSQL(node *ast.Node, translator *QueryExprTranslator) {
3941
if *node == nil {
4042
return
@@ -175,6 +177,8 @@ func (q *QueryExprTranslator) ConvertToEsQuery() (string, error) {
175177
return string(queryJSON), nil
176178
}
177179

180+
// TranslateToEsQuery The idea came from ast.Walk. Currently, the development focus implement for the node type that most likely used in our needs.
181+
// TODO: implement translator for node type that still not covered right now.
178182
func (q *QueryExprTranslator) TranslateToEsQuery(node *ast.Node) interface{} {
179183
if *node == nil {
180184
return nil

0 commit comments

Comments
 (0)