bug: log http response bodies in failed daemon calls

ibuildthecloud · ibuildthecloud · commit e7e923134d63 · 2024-10-21T16:35:27.000-07:00
diff --git a/pkg/engine/http.go b/pkg/engine/http.go
@@ -96,8 +96,8 @@ func (e *Engine) runHTTP(ctx context.Context, prg *types.Program, tool types.Too
 	defer resp.Body.Close()
 
 	if resp.StatusCode > 299 {
-		_, _ = io.ReadAll(resp.Body)
-		return nil, fmt.Errorf("error in request to [%s] [%d]: %s", toolURL, resp.StatusCode, resp.Status)
+		body, _ := io.ReadAll(resp.Body)
+		return nil, fmt.Errorf("error in request to [%s] [%d]: %s: %s", toolURL, resp.StatusCode, resp.Status, body)
 	}
 
 	content, err := io.ReadAll(resp.Body)

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,8 @@ func (e Engine) runHTTP(ctx context.Context, prg types.Program, tool types.Too`
`96`	`96`	`defer resp.Body.Close()`
`97`	`97`
`98`	`98`	`if resp.StatusCode > 299 {`
`99`		`- _, _ = io.ReadAll(resp.Body)`
`100`		`- return nil, fmt.Errorf("error in request to [%s] [%d]: %s", toolURL, resp.StatusCode, resp.Status)`
	`99`	`+ body, _ := io.ReadAll(resp.Body)`
	`100`	`+ return nil, fmt.Errorf("error in request to [%s] [%d]: %s: %s", toolURL, resp.StatusCode, resp.Status, body)`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`content, err := io.ReadAll(resp.Body)`