Skip to content

Commit 8cd146f

Browse files
Added and corrected test coverage
1 parent 61c8fd7 commit 8cd146f

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

index.test-d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ expectType<{
5757
defaultOne: string,
5858
defaultTwo: number,
5959
version: string,
60-
}>(BaseLevelTwo.defaultOptions);
60+
}>({ ...BaseLevelTwo.defaultOptions });
6161

6262
// Because 'version' is already provided, this needs no argument
6363
new BaseLevelTwo();
@@ -88,7 +88,7 @@ expectType<{
8888
defaultTwo: number,
8989
defaultThree: string[],
9090
version: string,
91-
}>(BaseLevelThree.defaultOptions);
91+
}>({ ...BaseLevelThree.defaultOptions });
9292

9393
// Because 'version' is already provided, this needs no argument
9494
new BaseLevelThree();

test/base.test.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,20 @@ test(".defaults({foo: 'bar'})", () => {
3333
const BaseWithDefaults = Base.defaults({ foo: "bar" });
3434
const defaultsTest = new BaseWithDefaults();
3535
const mergedOptionsTest = new BaseWithDefaults({ baz: "daz" });
36+
assert.equal(BaseWithDefaults.defaultOptions, { foo: "bar" });
3637
assert.equal(defaultsTest.options, { foo: "bar" });
3738
assert.equal(mergedOptionsTest.options, { foo: "bar", baz: "daz" });
3839
});
3940

41+
test(".defaults({foo: 'bar', baz: 'daz' })", () => {
42+
const BaseWithDefaults = Base.defaults({ foo: "bar" }).defaults({ baz: "daz" });
43+
const defaultsTest = new BaseWithDefaults();
44+
const mergedOptionsTest = new BaseWithDefaults({ faz: "boo" });
45+
assert.equal(BaseWithDefaults.defaultOptions, { foo: "bar", baz: "daz" });
46+
assert.equal(defaultsTest.options, { foo: "bar", baz: "daz" });
47+
assert.equal(mergedOptionsTest.options, { foo: "bar", baz: "daz", faz: "boo" });
48+
});
49+
4050
test(".plugin().defaults()", () => {
4151
const BaseWithPluginAndDefaults = Base.plugin(fooPlugin).defaults({
4252
baz: "daz",

0 commit comments

Comments
 (0)