Skip to content

Commit 68f6057

Browse files
committed
Merge branch 'main' of github.com:grafana/alloy into secret-filter-fuzz-testing
2 parents e4c0f52 + fd9c7d5 commit 68f6057

File tree

22 files changed

+618
-538
lines changed

22 files changed

+618
-538
lines changed

.drone/drone.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ depends_on:
530530
- Publish Linux alloy-devel container
531531
- Publish Linux alloy-devel-boringcrypto container
532532
image_pull_secrets:
533-
- dockerconfigjson
533+
- dockerconfigjson_gar
534534
kind: pipeline
535535
name: Deploy to deployment_tools
536536
platform:
@@ -543,7 +543,7 @@ steps:
543543
- echo "grafana/alloy-dev:$(bash ./tools/image-tag-docker)" > .image-tag
544544
image: alpine
545545
name: Create .image-tag
546-
- image: us.gcr.io/kubernetes-dev/drone/plugins/updater
546+
- image: us-docker.pkg.dev/grafanalabs-global/docker-deployment-tools-prod/updater
547547
name: Update deployment_tools
548548
settings:
549549
config_json: |
@@ -685,6 +685,12 @@ get:
685685
kind: secret
686686
name: dockerconfigjson
687687
---
688+
get:
689+
name: .dockerconfigjson
690+
path: secret/data/common/gar
691+
kind: secret
692+
name: dockerconfigjson_gar
693+
---
688694
get:
689695
name: .dockerconfigjson
690696
path: infra/data/ci/gcr-admin

.drone/pipelines/publish.jsonnet

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ linux_containers_jobs + windows_containers_jobs + [
183183
trigger: {
184184
ref: ['refs/heads/main'],
185185
},
186-
image_pull_secrets: ['dockerconfigjson'],
186+
image_pull_secrets: ['dockerconfigjson_gar'],
187187
steps: [
188188
{
189189
name: 'Create .image-tag',
@@ -196,7 +196,7 @@ linux_containers_jobs + windows_containers_jobs + [
196196
},
197197
{
198198
name: 'Update deployment_tools',
199-
image: 'us.gcr.io/kubernetes-dev/drone/plugins/updater',
199+
image: 'us-docker.pkg.dev/grafanalabs-global/docker-deployment-tools-prod/updater',
200200
settings: {
201201
config_json: |||
202202
{

.drone/util/secrets.jsonnet

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ local newSecret(name) = {
1111

1212
{
1313
dockerconfigjson: newSecret('dockerconfigjson').getFrom(path='secret/data/common/gcr', name='.dockerconfigjson'),
14+
dockerconfigjson_gar: newSecret('dockerconfigjson_gar').getFrom(path='secret/data/common/gar', name='.dockerconfigjson'),
1415
gcr_admin: newSecret('gcr_admin').getFrom(path='infra/data/ci/gcr-admin', name='.dockerconfigjson'),
1516

1617
// Agent Github App

.github/workflows/create_build_image.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
run: echo "image_tag=${FULL_TAG##*/}" >> $GITHUB_OUTPUT
3131

3232
- name: Login to DockerHub (from vault)
33-
uses: grafana/shared-workflows/actions/[email protected].0
33+
uses: grafana/shared-workflows/actions/[email protected].1
3434

3535
- run: |
3636
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
@@ -58,7 +58,7 @@ jobs:
5858
run: echo "image_tag=${FULL_TAG##*/}-boringcrypto" >> $GITHUB_OUTPUT
5959

6060
- name: Login to DockerHub (from vault)
61-
uses: grafana/shared-workflows/actions/[email protected].0
61+
uses: grafana/shared-workflows/actions/[email protected].1
6262

6363
- run: |
6464
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes

CHANGELOG.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ Main (unreleased)
2020

2121
- Add `go_table_fallback` arg to `pyroscope.ebpf` (@korniltsev)
2222

23+
- Memory optimizations in `pyroscope.scrape` (@korniltsev)
24+
2325
- Add the possibility to export span events as logs in `otelcol.connector.spanlogs`. (@steve-hb)
2426

2527
- Add json format support for log export via faro receiver (@ravishankar15)
@@ -34,6 +36,7 @@ Main (unreleased)
3436
- Better error handling for components (@cristiangreco)
3537
- Add namespace to `connection_info` metric (@cristiangreco)
3638
- Added table columns parsing (@cristiagreco)
39+
- Add enable/disable collector configurability to `database_observability.mysql`. This removes the `query_samples_enabled` argument, now configurable via enable/disable collector. (@fridgepoet)
3740

3841
### Bugfixes
3942

@@ -49,15 +52,10 @@ Main (unreleased)
4952

5053
- Add support for pushv1.PusherService Connect API in `pyroscope.receive_http`. (@simonswine)
5154

52-
- Add support for path prefixes in `pyroscope.scrape` to allow scraping targets behind a proxy or with custom URL paths. (@korniltsev)
53-
54-
- Fixes godeltaprof hiding (renaming `godeltaprof_*` profile names to regular ones). (@korniltsev)
55-
56-
- Change profile handling in `pyroscope.receive_http` and `pyroscope.write` components to use in-memory processing instead of pipes. (@marcsanmi)
55+
- Fixed an issue where `loki.process` would sometimes output live debugging entries out-of-order (@thampiotr)
5756

5857
- (_Experimental_) Fixed several out-of-memory bugs in `loki.secretfilter`. (@kelnage)
5958

60-
6159
v1.6.1
6260
-----------------
6361

@@ -239,6 +237,8 @@ v1.5.1
239237

240238
- For sharding targets during clustering, `loki.source.podlogs` now only takes into account some labels. (@ptodev)
241239

240+
- Improve instrumentation of `pyroscope.relabel` component. (@marcsanmi)
241+
242242
### Bugfixes
243243

244244
- Fixed an issue in the `pyroscope.write` component to prevent TLS connection churn to Pyroscope when the `pyroscope.receive_http` clients don't request keepalive (@madaraszg-tulip)

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@
2323
# Components:
2424
/internal/component/pyroscope/ @grafana/grafana-alloy-profiling-maintainers
2525
/internal/component/beyla/ @grafana/beyla
26-
/internal/component/database_observability/ @cristiangreco @matthewnolf
26+
/internal/component/database_observability/ @cristiangreco @matthewnolf @fridgepoet

docs/sources/reference/components/database_observability/database_observability.mysql.md

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,20 @@ database_observability.mysql "<LABEL>" {
2323

2424
You can use the following arguments with `database_observability.mysql`:
2525

26-
Name | Type | Description | Default | Required
27-
------------------------|----------------------|----------------------------------------------------------|---------|---------
28-
`data_source_name` | `secret` | [Data Source Name][] for the MySQL server to connect to. | | yes
29-
`forward_to` | `list(LogsReceiver)` | Where to forward log entries after processing. | | yes
30-
`collect_interval` | `duration` | How frequently to collect information from database. | `"1m"` | no
31-
`query_samples_enabled` | `bool` | Whether to enable collection of query samples. | `true` | no
26+
Name | Type | Description | Default | Required
27+
----------------------|----------------------|-----------------------------------------------------------|---------|----------
28+
`data_source_name` | `secret` | [Data Source Name][] for the MySQL server to connect to. | | yes
29+
`forward_to` | `list(LogsReceiver)` | Where to forward log entries after processing. | | yes
30+
`collect_interval` | `duration` | How frequently to collect information from database. | `"1m"` | no
31+
`disable_collectors` | `list(string)` | A list of collectors to disable from the default set. | | no
32+
`enable_collectors` | `list(string)` | A list of collectors to enable on top of the default set. | | no
33+
34+
The following collectors are enabled by default:
35+
36+
Name | Description
37+
----------------|-------------------------------------------------------
38+
`query_sample` | Collect query samples.
39+
`schema_table` | Collect schemas and tables from `information_schema`.
3240

3341
## Blocks
3442

internal/component/database_observability/mysql/collector/connection_info.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ import (
1111
"go.uber.org/atomic"
1212
)
1313

14+
const ConnectionInfoName = "connection_info"
15+
1416
var rdsRegex = regexp.MustCompile(`(?P<identifier>[^\.]+)\.([^\.]+)\.(?P<region>[^\.]+)\.rds\.amazonaws\.com`)
1517

1618
type ConnectionInfoArguments struct {
@@ -44,7 +46,7 @@ func NewConnectionInfo(args ConnectionInfoArguments) (*ConnectionInfo, error) {
4446
}
4547

4648
func (c *ConnectionInfo) Name() string {
47-
return "ConnectionInfo"
49+
return ConnectionInfoName
4850
}
4951

5052
func (c *ConnectionInfo) Start(ctx context.Context) error {

internal/component/database_observability/mysql/collector/query_sample.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
const (
2222
OP_QUERY_SAMPLE = "query_sample"
2323
OP_QUERY_PARSED_TABLE_NAME = "query_parsed_table_name"
24+
QuerySampleName = "query_sample"
2425
)
2526

2627
const selectQuerySamples = `
@@ -67,7 +68,7 @@ func NewQuerySample(args QuerySampleArguments) (*QuerySample, error) {
6768
}
6869

6970
func (c *QuerySample) Name() string {
70-
return "QuerySample"
71+
return QuerySampleName
7172
}
7273

7374
func (c *QuerySample) Start(ctx context.Context) error {

internal/component/database_observability/mysql/collector/schema_table.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ const (
2424
OP_SCHEMA_DETECTION = "schema_detection"
2525
OP_TABLE_DETECTION = "table_detection"
2626
OP_CREATE_STATEMENT = "create_statement"
27+
SchemaTableName = "schema_table"
2728
)
2829

2930
const (
@@ -127,7 +128,7 @@ func NewSchemaTable(args SchemaTableArguments) (*SchemaTable, error) {
127128
}
128129

129130
func (c *SchemaTable) Name() string {
130-
return "SchemaTable"
131+
return SchemaTableName
131132
}
132133

133134
func (c *SchemaTable) Start(ctx context.Context) error {

0 commit comments

Comments
 (0)