add symdb write closer option

Author: kolesnikovae

pkg/experiment/block/compaction.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
+	"io"
 	"os"
 	"slices"
 	"sort"
@@ -547,13 +548,16 @@ func newSymbolsRewriter() *symbolsRewriter {
 		buf: buf,
 		rw:  make(map[*Dataset]*symdb.Rewriter),
 		w: symdb.NewSymDB(&symdb.Config{
-			Version:       symdb.FormatV3,
-			Writer:        buf,
-			NoStatsUpdate: true,
+			Version: symdb.FormatV3,
+			Writer:  &nopWriteCloser{buf},
 		}),
 	}
 }
 
+type nopWriteCloser struct{ io.Writer }
+
+func (*nopWriteCloser) Close() error { return nil }
+
 func (s *symbolsRewriter) rewriteRow(e ProfileEntry) (err error) {
 	rw := s.rewriterFor(e.Dataset)
 	e.Row.ForStacktraceIDsValues(func(values []parquet.Value) {

pkg/experiment/query_backend/query.go

@@ -208,7 +208,7 @@ func (q *blockContext) lookupDatasets() error {
 		return q.obj.ReadMetadata(ctx)
 	})
 	g.Go(func() error {
-		return ds.Open(q.ctx, block.SectionTSDB)
+		return ds.Open(ctx, block.SectionTSDB)
 	})
 	if err := g.Wait(); err != nil {
 		return err

pkg/phlaredb/symdb/block_writer_v3.go

@@ -63,6 +63,9 @@ func newEncodersV3() encodersV3 {
 
 func (w *writerV3) writePartitions(partitions []*PartitionWriter) (err error) {
 	if dst := w.config.Writer; dst != nil {
+		defer func() {
+			_ = w.config.Writer.Close()
+		}()
 		return w.writePartitionsWithWriter(withWriterOffset(dst), partitions)
 	}
 	if err = os.MkdirAll(w.config.Dir, 0o755); err != nil {
@@ -74,7 +77,7 @@ func (w *writerV3) writePartitions(partitions []*PartitionWriter) (err error) {
 		return err
 	}
 	defer func() {
-		err = f.Close()
+		_ = f.Close()
 		w.files = []block.File{f.meta()}
 	}()
 	return w.writePartitionsWithWriter(f.w, partitions)

pkg/phlaredb/symdb/symdb.go

@@ -97,17 +97,22 @@ type SymDB struct {
 }
 
 type Config struct {
-	Dir           string
-	Version       FormatVersion
-	Stacktraces   StacktracesConfig
-	Parquet       ParquetConfig
-	NoStatsUpdate bool
-	Writer        io.Writer // V3 only.
-}
+	Version FormatVersion
+	// Output writer. Optional, V3 only.
+	Writer io.WriteCloser
 
-type StacktracesConfig struct {
 	// DEPRECATED: the parameter is not used and
 	// will be removed in the future versions.
+	Dir string
+	// DEPRECATED: the parameter is not used and
+	// will be removed in the future versions.
+	Stacktraces StacktracesConfig
+	// DEPRECATED: the parameter is not used and
+	// will be removed in the future versions.
+	Parquet ParquetConfig
+}
+
+type StacktracesConfig struct {
 	MaxNodesPerChunk uint32
 }
 
@@ -169,10 +174,8 @@ func NewSymDB(c *Config) *SymDB {
 		db.config.Version = FormatV2
 		db.writer = newWriterV2(c)
 	}
-	if !c.NoStatsUpdate {
-		db.wg.Add(1)
-		go db.updateStatsLoop()
-	}
+	db.wg.Add(1)
+	go db.updateStatsLoop()
 	return db
 }