profileStore: add err check, return err if phlareparquet.CopyAsRowGroups returns err (#3421)

korniltsev · web-flow · commit dd0aa0c8fe4b · 2024-07-15T11:26:05.000+08:00
diff --git a/pkg/phlaredb/profile_store.go b/pkg/phlaredb/profile_store.go
@@ -381,6 +381,9 @@ func (s *profileStore) writeRowGroups(path string, rowGroups []parquet.RowGroup)
 		readers[i] = rg.Rows()
 	}
 	n, numRowGroups, err = phlareparquet.CopyAsRowGroups(s.writer, schemav1.NewMergeProfilesRowReader(readers), s.cfg.MaxBufferRowCount)
+	if err != nil {
+		return 0, 0, err
+	}
 
 	if err := s.writer.Close(); err != nil {
 		return 0, 0, err

Original file line number	Diff line number	Diff line change
`@@ -381,6 +381,9 @@ func (s *profileStore) writeRowGroups(path string, rowGroups []parquet.RowGroup)`
`381`	`381`	`readers[i] = rg.Rows()`
`382`	`382`	`}`
`383`	`383`	`n, numRowGroups, err = phlareparquet.CopyAsRowGroups(s.writer, schemav1.NewMergeProfilesRowReader(readers), s.cfg.MaxBufferRowCount)`
	`384`	`+ if err != nil {`
	`385`	`+ return 0, 0, err`
	`386`	`+ }`
`384`	`387`
`385`	`388`	`if err := s.writer.Close(); err != nil {`
`386`	`389`	`return 0, 0, err`