Skip to content

Commit e8f4d85

Browse files
authored
fix(v2): disable parquet page index (#4036)
1 parent 56f1fd2 commit e8f4d85

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

Diff for: pkg/experiment/block/dataset.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ func (s *Dataset) open(ctx context.Context, sections ...Section) (err error) {
153153
sc := sc
154154
g.Go(util.RecoverPanic(func() error {
155155
if openErr := sc.open(ctx, s); openErr != nil {
156-
return fmt.Errorf("openning section %v: %w", s.section(sc).name, openErr)
156+
return fmt.Errorf("opening section %v: %w", s.section(sc).name, openErr)
157157
}
158158
return nil
159159
}))

Diff for: pkg/experiment/block/section_profiles.go

+2
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,15 @@ func openProfileTable(_ context.Context, s *Dataset) (err error) {
3333
s.inMemoryBucket(buf), s.obj.path, offset, size,
3434
0, // Do not prefetch the footer.
3535
parquet.SkipBloomFilters(true),
36+
parquet.SkipPageIndex(true),
3637
parquet.FileReadMode(parquet.ReadModeSync),
3738
parquet.ReadBufferSize(4<<10))
3839
} else {
3940
s.profiles, err = openParquetFile(
4041
s.obj.storage, s.obj.path, offset, size,
4142
estimateFooterSize(size),
4243
parquet.SkipBloomFilters(true),
44+
parquet.SkipPageIndex(true),
4345
parquet.FileReadMode(parquet.ReadModeAsync),
4446
parquet.ReadBufferSize(estimateReadBufferSize(size)))
4547
}

Diff for: pkg/phlaredb/symdb/block_reader.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ func (r *Reader) readIndexSection(ctx context.Context, offset, size int64) error
246246
}
247247
r.index, err = OpenIndex(buf)
248248
if err != nil {
249-
return fmt.Errorf("openning index: %w", err)
249+
return fmt.Errorf("opening index: %w", err)
250250
}
251251
return nil
252252
}

Diff for: pkg/phlaredb/symdb/block_reader_parquet.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ func openParquetFiles(ctx context.Context, r *Reader) error {
153153
return err
154154
}
155155
if err = fp.Open(ctx, r.bucket, fm, options...); err != nil {
156-
return fmt.Errorf("openning file %q: %w", n, err)
156+
return fmt.Errorf("opening file %q: %w", n, err)
157157
}
158158
return nil
159159
})

0 commit comments

Comments
 (0)