Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky aggregation test #3895

Open
kolesnikovae opened this issue Feb 6, 2025 · 0 comments
Open

Flaky aggregation test #3895

kolesnikovae opened this issue Feb 6, 2025 · 0 comments

Comments

@kolesnikovae
Copy link
Collaborator

Periodically, the Test_Aggregation_Error test fails in CI:

=== Failed
=== FAIL: pkg/distributor/aggregator Test_Aggregation_Error/First_aggregation_failed (0.01s)
    aggregator_test.go:156: 
        	Error Trace:	/home/runner/work/pyroscope/pyroscope/pkg/distributor/aggregator/aggregator_test.go:156
        	Error:      	Target error should be in err chain:
        	            	expected: "context canceled"
        	            	in chain: 
        	Test:       	Test_Aggregation_Error/First_aggregation_failed
    aggregator_test.go:160: 
        	Error Trace:	/home/runner/work/pyroscope/pyroscope/pkg/distributor/aggregator/aggregator_test.go:160
        	Error:      	An error is expected but got nil.
        	Test:       	Test_Aggregation_Error/First_aggregation_failed
        	Messages:   	context canceled
    --- FAIL: Test_Aggregation_Error/First_aggregation_failed (0.01s)

Presumably, it should be caused by the configured 10ms period. One way to solve it is to run test multiple times, or increase the 10ms period (for that specific test)

@kolesnikovae kolesnikovae added type/bug Something isn't working and removed type/bug Something isn't working labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant