Skip to content
This repository was archived by the owner on Mar 18, 2025. It is now read-only.

Commit 70a9df8

Browse files
committed
Removed the hack for duplicates
The specific hack is not required with the new local model. Regarding the original issue we need to get the real problem and apply a complete solution. We expect to fix with a PR for github.com//issues/11
1 parent a97d401 commit 70a9df8

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

pkg/remotewrite/metrics.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,8 @@ func (ms *metricsStorage) update(sample metrics.Sample, add func(*metrics.Metric
5151
ms.m[m.Name] = m
5252
}
5353

54-
// TODO: this is just avoiding duplicates with the previous
55-
// Implement a better and complete solution
56-
// maybe discard any timestamp < latest?
54+
// TODO: https://github.com/grafana/xk6-output-prometheus-remote/issues/11
5755
//
58-
//current.Time = sample.Time // to avoid duplicates in timestamps
59-
6056
// Sometimes remote write endpoint throws an error about duplicates even if the values
6157
// sent were different. By current observations, this is a hard to repeat case and
6258
// potentially a bug.

0 commit comments

Comments
 (0)