Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHA256BytesCodecTests Has Wrong Source File Name #12681

Closed
jeffscottbrown opened this issue Aug 30, 2022 · 1 comment
Closed

SHA256BytesCodecTests Has Wrong Source File Name #12681

jeffscottbrown opened this issue Aug 30, 2022 · 1 comment
Labels
info: good first issue type: trivial

Comments

@jeffscottbrown
Copy link
Member

jeffscottbrown commented Aug 30, 2022 •
edited
Loading

The org.grails.web.codecs.SHA256BytesCodecTests class is defined in a source file named SHA256BytesCodec.groovy instead of SHA256BytesCodecTests.groovy. See https://github.com/grails/grails-core/blob/c1e4a3bca157ecc2a24313d778ce2f40e1520bc5/grails-codecs/src/test/groovy/org/grails/web/codecs/SHA256BytesCodec.groovy.
jeffscottbrown added a commit that referenced this issue Aug 30, 2022
@jeffscottbrown
Rename SHA256BytesCodec.groovy to SHA256BytesCodecTests.groovy
0b9f233 
See #12681
@jeffscottbrown jeffscottbrown mentioned this issue Aug 30, 2022
Merged
@jeffscottbrown
Copy link
Member Author

@puneetbehl Do you feel this issue can be closed now that github.com/grails/grails-core/pull/12682 has been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
info: good first issue type: trivial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffscottbrown @puneetbehl