Add network error when service endpoint statuses are unknown (vmware-tanzu#1124)

Author: zhengxiexie

pkg/nsx/services/inventory/build_test.go

@@ -1267,7 +1267,7 @@ func TestBuildService(t *testing.T) {
 		assert.Equal(t, NetworkStatusUnhealthy, containerApplication.NetworkStatus)
 
 		// Verify network errors
-		assert.Equal(t, 3, len(containerApplication.NetworkErrors))
+		assert.Equal(t, 4, len(containerApplication.NetworkErrors))
 
 		// Create a map of error messages for easier verification
 		errorMessages := make(map[string]bool)

pkg/nsx/services/inventory/builder.go

@@ -322,6 +322,8 @@ func (s *InventoryService) BuildService(service *corev1.Service) (retry bool) {
 		return
 	}
 
+	var networkErrors []common.NetworkError
+
 	// Get pods from the endpoint
 	netStatus := NetworkStatusHealthy
 	status := InventoryStatusUp
@@ -334,17 +336,22 @@ func (s *InventoryService) BuildService(service *corev1.Service) (retry bool) {
 		status = InventoryStatusUp
 	} else if hasAddr {
 		status = InventoryStatusUnknown
+		networkErrors = append(networkErrors, common.NetworkError{
+			ErrorMessage: "Service endpoint status is unknown",
+		})
 	} else if hasSelector {
 		// Only mark as down if service has selector but no endpoints
 		status = InventoryStatusDown
 		netStatus = NetworkStatusUnhealthy
+		networkErrors = append(networkErrors, common.NetworkError{
+			ErrorMessage: "Failed to get endpoints for Service",
+		})
 	} else {
 		// Service without a selector is valid even without endpoints
 		status = InventoryStatusUp
 	}
 
 	// Get network errors from service annotations
-	var networkErrors []common.NetworkError
 	if status != InventoryStatusUp {
 		// Check for NCP errors in service annotations
 		for key, value := range service.Annotations {

pkg/nsx/services/inventory/retrieval.go

@@ -14,7 +14,7 @@ func GetPodIDsFromEndpoint(ctx context.Context, c client.Client, name string, na
 	podIDs = []string{}
 	hasAddr = false
 
-	// Get the endpoints object corresponding to the service
+	// Get the endpoint object corresponding to the service
 	endpoint := &v1.Endpoints{}
 	err := c.Get(ctx, types.NamespacedName{
 		Name:      name,
@@ -30,7 +30,7 @@ func GetPodIDsFromEndpoint(ctx context.Context, c client.Client, name string, na
 	for _, subset := range endpoint.Subsets {
 		for _, address := range subset.Addresses {
 			hasAddr = true
-			if address.TargetRef != nil && address.TargetRef.Kind == "Pod" {
+			if address.TargetRef != nil && (address.TargetRef.Kind == "Pod" || address.TargetRef.Kind == "VirtualMachine") {
 				podIDs = append(podIDs, string(address.TargetRef.UID))
 			}
 		}
@@ -73,7 +73,7 @@ func GetServicesUIDByPodUID(ctx context.Context, c client.Client, podUID types.U
 
 	var serviceUIDs []string
 	for _, svc := range serviceList.Items {
-		// Get the endpoints object associated with the service
+		// Get the endpoint object associated with the service
 		endpoints := &v1.Endpoints{}
 		err := c.Get(ctx, types.NamespacedName{Name: svc.Name, Namespace: namespace}, endpoints)
 		if err != nil {