Fix maximum subnetport number in a subnet (vmware-tanzu#783)

yanjunz97 · web-flow · commit eaaad7c04170 · 2024-09-27T14:41:26.000+08:00
Signed-off-by: Yanjun Zhou &lt;zhouya@vmware.com&gt;
diff --git a/pkg/controllers/common/utils.go b/pkg/controllers/common/utils.go
@@ -36,7 +36,9 @@ func AllocateSubnetFromSubnetSet(subnetSet *v1alpha1.SubnetSet, vpcService servi
 			// totalIP will be overrided if IpAddresses are specified.
 			totalIP, _ = util.CalculateIPFromCIDRs(nsxSubnet.IpAddresses)
 		}
-		if portNums < totalIP-3 {
+		// NSX reserves 4 ip addresses in each subnet for network address, gateway address,
+		// dhcp server address and broadcast address.
+		if portNums < totalIP-4 {
 			return *nsxSubnet.Path, nil
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,9 @@ func AllocateSubnetFromSubnetSet(subnetSet *v1alpha1.SubnetSet, vpcService servi`
`36`	`36`	`// totalIP will be overrided if IpAddresses are specified.`
`37`	`37`	`totalIP, _ = util.CalculateIPFromCIDRs(nsxSubnet.IpAddresses)`
`38`	`38`	`}`
`39`		`- if portNums < totalIP-3 {`
	`39`	`+ // NSX reserves 4 ip addresses in each subnet for network address, gateway address,`
	`40`	`+ // dhcp server address and broadcast address.`
	`41`	`+ if portNums < totalIP-4 {`
`40`	`42`	`return *nsxSubnet.Path, nil`
`41`	`43`	`}`
`42`	`44`	`}`