Fix maximum subnetport number in a subnet (vmware-tanzu#783)

Signed-off-by: Yanjun Zhou <[email protected]>
gran-vmv · Sep 27, 2024 · eaaad7c · eaaad7c
1 parent 6202688
commit eaaad7c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/controllers/common/utils.go b/pkg/controllers/common/utils.go
@@ -36,7 +36,9 @@ func AllocateSubnetFromSubnetSet(subnetSet *v1alpha1.SubnetSet, vpcService servi
 			// totalIP will be overrided if IpAddresses are specified.
 			totalIP, _ = util.CalculateIPFromCIDRs(nsxSubnet.IpAddresses)
 		}
-		if portNums < totalIP-3 {
+		// NSX reserves 4 ip addresses in each subnet for network address, gateway address,
+		// dhcp server address and broadcast address.
+		if portNums < totalIP-4 {
 			return *nsxSubnet.Path, nil
 		}
 	}