Skip to content

Commit 051c63c

Browse files
committed
Add ext4 to the syschecks FS check
We semi-support ext4 but in the syscheck we will now check for both ext2 and ext4, as currently ext4 is always detected as ext2, but in the future if ext4 is returned we should also treat this as ext4. Issue redpanda-data#13469.
1 parent 328c245 commit 051c63c

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/v/syschecks/syschecks.cc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,12 @@ ss::future<> disk(const ss::sstring& path) {
5151
return ss::check_direct_io_support(path).then([path] {
5252
return ss::file_system_at(path).then([path](auto fs) {
5353
checklog.info0("Detected file system type is {}", to_string(fs));
54-
// all of ext2, 3 and 4 are detected as ext2, so we just assume an
55-
// ext2 detection means ext4 for now, see:
54+
// Currently, all of ext2, 3 and 4 are detected as ext2, so we just
55+
// assume an ext2 detection means ext4 for now, see:
5656
// https://github.com/redpanda-data/redpanda/issues/13469
57-
if (fs == ss::fs_type::ext2) {
57+
// We also still check for ext4, since if that is returned it means
58+
// that seastar has been fixed to be able to detect ext4.
59+
if (fs == ss::fs_type::ext2 || fs == ss::fs_type::ext4) {
5860
checklog.warn(
5961
"Path: `{}' is on ext4, not XFS. This will probably work, "
6062
"but Redpanda is only tested on XFS and XFS is recommended "

0 commit comments

Comments
 (0)