Skip to content

Commit 272993f

Browse files
committed
[explorations/wikipedia] removed inline comment because it is now discussed in #11 and #12
1 parent 8560712 commit 272993f

File tree

1 file changed

+7
-38
lines changed

1 file changed

+7
-38
lines changed

explorations/wikipedia/js/main.mjs

+7-38
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,12 @@ function getELementLineWidthAndEmInPx(elem) {
263263
}
264264

265265
function _runion_01_columns(availableWidthEn) {
266+
// TODO: Could be cool to configure the unknowns via the testing rig.
267+
// Would need to reach into the window, could, for that matter, also
268+
// be done by the user-settings dialogue however, this is not meant
269+
// to be an end-user-facing setting, just a tool to get the algorithm
270+
// dialed in.
271+
266272
/*
267273
* columnConfig:
268274
* This will likely be dependent on the locale!
@@ -326,45 +332,8 @@ function _runion_01_columns(availableWidthEn) {
326332
throw new Error(`Can\'t compose column setup for availableWidthEn: ${availableWidthEn}!`);
327333
}
328334

335+
// Characters per line runion
329336
function runion_01 (elem) {
330-
// FIXME:
331-
// not sure where this applies actually, so I'll make this variable.
332-
//
333-
// When layout changes, this will re-run, hence a good start would
334-
// be to undo all changes that have been applied before.
335-
//
336-
// Could apply to:
337-
//
338-
// all of the text:
339-
// h1,h2,h3 markup (anything else likely as well)would be kept alive
340-
// we could make some of these column-span h1, or h1+h2, or h1+h2+h3
341-
// so, we'd need to select col-spanning elements and mark them up
342-
// could be done in pure css or by js
343-
//
344-
// I'm not sure to which amount of text a "runion" aplies, or what it
345-
// is exactly. It's a "run of text" but i don't know how to determine
346-
// its start or end, so this would have to be configurable, too.
347-
//
348-
// A col-span element obviously ends a runion. Hence, a runion could
349-
// be all elements between col-span elements.
350-
// A runion could also be bigger than the screen, requiring scrolling
351-
// up and down, hence, a runion could end somewhere in between. We
352-
// could insert an empty/no-headline-just-margin col-span element in
353-
// between OR we could insert it within the runion and make the CSS
354-
// apply to to more than one screen of the same runion.
355-
//
356-
//
357-
// additionally, whatever counts as a runion, if its textContent length
358-
// is lower than 365, we'll mark it with a special, alarming, background
359-
// color, because it is not specified how to handle in the Runion 1 case:
360-
// #shorter text strings later#
361-
//
362-
// Would be cool to configure the unknowns via the testing rig ...
363-
// would need to reach into the window.
364-
// Could, for that matter, also be done by the user-settings dialogue
365-
// however, this is not meant to be a end-user-facing setting, just a
366-
// tool to get the algorithm dialed in.
367-
368337
var [widthPx, emInPx] = getELementLineWidthAndEmInPx(elem)
369338
// NOTE: rounding errors made e.g. 4-column layouts appear as
370339
// 3-columns. The CSS-columns property can't be forced to a definite

0 commit comments

Comments
 (0)