Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Forbid export" feature; and fix bug in makeAddPgTableConditionPlugin #2350

Open
benjie opened this issue Feb 3, 2025 · 0 comments
Open

Comments

@benjie
Copy link
Member

benjie commented Feb 3, 2025

build should never be exported; it's huge and contains loads of things that are likely not exportable without sufficient work. However, we only meet this issue when someone tries to export the schema - it would be great to flag this issue earlier.

I suggest that we forbid exporting of particular objects (e.g. by adding some custom property such as $$export: false) and then have EXPORTABLE itself throw if it sees these values. This will help catch these problems at source, for example this one:

conditionFieldSpec.applyPlan = EXPORTABLE(
(build, conditionGenerator, sql) =>

@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Feb 3, 2025
@benjie benjie changed the title "Forbid export" feature "Forbid export" feature; and fix bug in makeAddPgTableConditionPlugin Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🌳 Triage
Development

No branches or pull requests

1 participant