Skip to content

Commit 14214a3

Browse files
committed
Switch Plottable to a Protocol
1 parent 6910a18 commit 14214a3

22 files changed

+410
-590
lines changed

docs/source/api/plotter.rst

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,6 @@ Plotter Class
1818
:inherited-members:
1919
:show-inheritance:
2020

21-
Plottable Interface
22-
----------------------
23-
.. automodule:: graphistry.Plottable
24-
:members:
25-
:undoc-members:
26-
:inherited-members:
27-
:show-inheritance:
2821

2922
PlotterBase Class
3023
----------------------

graphistry/Engine.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ def resolve_engine(
3939
return Engine(engine.value)
4040

4141
if g_or_df is not None:
42-
# work around circular dependency
4342
from graphistry.Plottable import Plottable
4443
if isinstance(g_or_df, Plottable):
4544
if g_or_df._nodes is not None and g_or_df._edges is not None:
@@ -48,7 +47,6 @@ def resolve_engine(
4847
warnings.warn(f'Edges and nodes must be same type for auto engine selection, got: {type(g_or_df._edges)} and {type(g_or_df._nodes)}')
4948
g_or_df = g_or_df._edges if g_or_df._edges is not None else g_or_df._nodes
5049

51-
if g_or_df is not None:
5250
if isinstance(g_or_df, pd.DataFrame):
5351
return Engine.PANDAS
5452

0 commit comments

Comments
 (0)