fix(imports): replace relative imports with absolute imports in GFQL modules (#681)

* fix(imports): replace relative imports with absolute imports in GFQL modules

- Replace all '..' relative imports with absolute 'graphistry.' imports
- Fixes pip install issues caused by relative imports
- Add lint check to prevent future relative imports

The relative imports were breaking module resolution when installed via pip.
All imports now use absolute paths from the graphistry package root.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* docs(changelog): add v0.38.3 entry for import fixes

- Document fix for relative imports in GFQL modules
- Note addition of lint check for relative imports

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* fix(models): add missing __init__.py files for gfql modules

- Add empty __init__.py files to graphistry.models.gfql directories
- Fixes ModuleNotFoundError when importing after pip install
- Add docker test scripts to verify pip install works
- Add CI job to test pip install across Python versions

The missing __init__.py files prevented Python from recognizing
the gfql directories as packages, causing import errors after
pip install.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* chore: remove temporary minimal test script

* refactor(ci): move pip install test to step in test-minimal-python

- Remove separate test-pip-install job
- Add Docker pip install test as step after typecheck
- Ensures packaging is tested after lint/typecheck pass
- Reduces CI complexity while maintaining test coverage

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* docs(changelog): update PR reference and details

* style: fix import order to follow project conventions

- Typing imports first
- Then stdlib/third-party imports
- One empty line
- Then package global imports (from graphistry...)
- Then local imports (from .)
- Two empty lines before class/function definitions

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* style: alphabetize imports within sections

- Sort imports alphabetically within each import section
- Maintains proper import order: typing, stdlib/third-party, package, local
- Improves code consistency and readability

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>

Author: lmeyerov

.github/workflows/ci.yml

@@ -60,6 +60,12 @@ jobs:
         source pygraphistry/bin/activate
         ./bin/typecheck.sh
 
+    - name: Test pip install (Docker)
+      env:
+        PYTHON_VERSION: ${{ matrix.python-version }}
+      run: |
+        ./docker/test-pip-install.sh
+
     - name: Minimal tests
       run: |
         source pygraphistry/bin/activate

CHANGELOG.md

@@ -7,6 +7,15 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ## Dev
 
+## [0.38.3 - 2025-06-24]
+
+### Fixed
+* Fix relative imports in GFQL modules that broke pip install (#681)
+  * Replace all `..` relative imports with absolute `graphistry.` imports
+  * Add missing `__init__.py` files in `graphistry.models.gfql` subdirectories
+  * Add lint check in `bin/lint.sh` to prevent future relative imports
+  * Add Docker-based pip install test to CI pipeline
+
 ## [0.38.2 - 2025-06-24]
 
 ### Added

bin/lint.sh

@@ -23,3 +23,11 @@ flake8 \
   --max-complexity=10 \
   --max-line-length=127 \
   --statistics
+
+# Check for relative imports with '..' using flake8-quotes or custom regex
+# This will fail if any relative imports with .. are found
+echo "Checking for relative imports with '..' ..."
+if grep -r "from \.\." graphistry --include="*.py" --exclude-dir="__pycache__"; then
+    echo "ERROR: Found relative imports with '..'. Use absolute imports instead."
+    exit 1
+fi

docker/test-pip-install.sh

@@ -0,0 +1,42 @@
+#!/bin/bash
+set -ex
+
+# Test PyGraphistry pip install in a clean environment
+# This verifies that all imports work correctly after pip install
+
+echo "=== Testing PyGraphistry pip install ==="
+
+PYTHON_VERSION=${PYTHON_VERSION:-3.11}
+
+# Run in Docker container with inline Python test
+docker run --rm \
+  -v "$(pwd)":/workspace \
+  python:${PYTHON_VERSION}-slim \
+  bash -c "cd /workspace && pip install . && python -c '
+import sys
+import traceback
+
+try:
+    print(\"Testing: import graphistry\")
+    import graphistry
+    print(\"✓ Success: import graphistry\")
+    
+    print(\"\\nTesting: from graphistry.compute.predicates.types import NormalizedIsInElement\")
+    from graphistry.compute.predicates.types import NormalizedIsInElement
+    print(\"✓ Success: predicates.types import\")
+    
+    print(\"\\nTesting: from graphistry.models.gfql.types.temporal import DateTimeWire\")
+    from graphistry.models.gfql.types.temporal import DateTimeWire
+    print(\"✓ Success: gfql.types.temporal import\")
+    
+    print(\"\\nTesting: from graphistry.compute.ast_temporal import TemporalValue\")
+    from graphistry.compute.ast_temporal import TemporalValue
+    print(\"✓ Success: ast_temporal import\")
+    
+    print(\"\\nAll imports successful!\")
+    sys.exit(0)
+except Exception as e:
+    print(f\"\\n✗ Error: {type(e).__name__}: {e}\")
+    traceback.print_exc()
+    sys.exit(1)
+'"

graphistry/compute/ast_temporal.py

@@ -1,21 +1,19 @@
+from typing import Any, Dict, Union
 from abc import ABC, abstractmethod
-from datetime import datetime, date, time
-from typing import Dict, Any, Union, TYPE_CHECKING
-import pandas as pd
+from datetime import date, datetime, time
 from dateutil import parser as date_parser  # type: ignore[import]
+import pandas as pd
 import pytz  # type: ignore[import]
 
+from graphistry.models.gfql.types.temporal import DateTimeWire, DateWire, TimeWire, TemporalWire
 from graphistry.utils.json import JSONVal
 
-if TYPE_CHECKING:
-    from ..models.gfql.types.temporal import DateTimeWire, DateWire, TimeWire, TemporalWire
-
 
 class TemporalValue(ABC):
     """Base class for temporal values with tagging support"""
 
     @abstractmethod
-    def to_json(self) -> 'TemporalWire':
+    def to_json(self) -> TemporalWire:
         """Serialize to JSON-compatible dictionary"""
         pass
 
@@ -64,9 +62,8 @@ def _parse_iso8601(self, value: str, timezone: str) -> pd.Timestamp:
 
         return pd.Timestamp(dt)
 
-    def to_json(self) -> 'DateTimeWire':
+    def to_json(self) -> DateTimeWire:
         """Return dict for tagged temporal value"""
-        from ..models.gfql.types.temporal import DateTimeWire
         result: DateTimeWire = {
             "type": "datetime",
             "value": self.value,
@@ -94,9 +91,8 @@ def _parse_date(self, value: str) -> date:
         """Parse date string in ISO format (YYYY-MM-DD)"""
         return date_parser.isoparse(value).date()
 
-    def to_json(self) -> 'DateWire':
+    def to_json(self) -> DateWire:
         """Return dict for tagged temporal value"""
-        from ..models.gfql.types.temporal import DateWire
         result: DateWire = {
             "type": "date",
             "value": self.value
@@ -130,9 +126,8 @@ def _parse_time(self, value: str) -> time:
             # Extract time from full datetime
             return date_parser.isoparse(value).time()
 
-    def to_json(self) -> 'TimeWire':
+    def to_json(self) -> TimeWire:
         """Return dict for tagged temporal value"""
-        from ..models.gfql.types.temporal import TimeWire
         result: TimeWire = {
             "type": "time", 
             "value": self.value

graphistry/compute/predicates/comparison.py

@@ -1,15 +1,15 @@
-from typing import Union, TYPE_CHECKING, Literal, Dict, cast, overload
-import pandas as pd
+from typing import Dict, Literal, TYPE_CHECKING, Union, cast, overload
+from datetime import date, datetime, time
 import numpy as np
-from datetime import datetime, date, time
+import pandas as pd
 
-from .ASTPredicate import ASTPredicate
-from ..ast_temporal import TemporalValue, DateTimeValue, DateValue, TimeValue
-from ...models.gfql.coercions.temporal import to_ast
-from ...models.gfql.types.guards import is_native_numeric, is_any_temporal, is_string
-from graphistry.models.gfql.types.predicates import ComparisonInput, BetweenBoundInput
-from ...utils.json import JSONVal
+from graphistry.compute.ast_temporal import DateTimeValue, DateValue, TemporalValue, TimeValue
 from graphistry.compute.typing import SeriesT
+from graphistry.models.gfql.coercions.temporal import to_ast
+from graphistry.models.gfql.types.guards import is_any_temporal, is_native_numeric, is_string
+from graphistry.models.gfql.types.predicates import BetweenBoundInput, ComparisonInput
+from graphistry.utils.json import JSONVal
+from .ASTPredicate import ASTPredicate
 
 if TYPE_CHECKING:
     # Note: pd.Series[T] syntax not supported in Python 3.8

graphistry/compute/predicates/is_in.py

@@ -1,17 +1,16 @@
 from typing import Any, List, Union
-from .types import NormalizedIsInElement, NormalizedScalar, NormalizedNumeric
-import pandas as pd
+from datetime import date, datetime, time
 import numpy as np
-from datetime import datetime, date, time
+import pandas as pd
 
+from graphistry.compute.typing import SeriesT
+from graphistry.models.gfql.coercions.temporal import to_native
+from graphistry.models.gfql.types.guards import is_any_temporal, is_basic_scalar
+from graphistry.models.gfql.types.predicates import IsInElementInput
+from graphistry.models.gfql.types.temporal import DateTimeWire, DateWire, TemporalWire, TimeWire
 from graphistry.utils.json import assert_json_serializable
 from .ASTPredicate import ASTPredicate
-# Temporal value classes imported for type checking only
-from ...models.gfql.coercions.temporal import to_native
-from ...models.gfql.types.guards import is_basic_scalar, is_any_temporal
-from graphistry.models.gfql.types.predicates import IsInElementInput
-from graphistry.models.gfql.types.temporal import TemporalWire, DateTimeWire, DateWire, TimeWire
-from graphistry.compute.typing import SeriesT
+from .types import NormalizedIsInElement, NormalizedNumeric, NormalizedScalar
 
 
 class IsIn(ASTPredicate):

graphistry/compute/predicates/types.py

@@ -1,11 +1,10 @@
 """Type definitions for predicates"""
-from typing import Union, Literal
-import pandas as pd
+from typing import Literal, Union
+from datetime import date, datetime, time
 import numpy as np
-from datetime import datetime, date, time
+import pandas as pd
 
-# Import temporal wire types
-from ...models.gfql.types.temporal import DateTimeWire, DateWire, TimeWire
+from graphistry.models.gfql.types.temporal import DateTimeWire, DateWire, TimeWire
 
 # Normalized types after processing inputs
 NormalizedNumeric = Union[int, float, np.number]

graphistry/models/gfql/__init__.py

@@ -8,7 +8,7 @@
 from typing import Union
 import numpy as np
 
-from ..types.numeric import NativeNumeric
+from graphistry.models.gfql.types.numeric import NativeNumeric
 
 
 def to_native(val: NativeNumeric) -> NativeNumeric:

graphistry/models/gfql/coercions/__init__.py

@@ -8,10 +8,10 @@
 from datetime import datetime, date, time
 import pandas as pd
 
-from ....compute.ast_temporal import (
+from graphistry.compute.ast_temporal import (
     TemporalValue, DateTimeValue, DateValue, TimeValue
 )
-from ..types.temporal import NativeTemporal, TemporalWire
+from graphistry.models.gfql.types.temporal import NativeTemporal, TemporalWire
 
 
 # ============= To AST Transforms =============

graphistry/models/gfql/coercions/numeric.py

@@ -5,6 +5,9 @@
 """
 
 from typing import Any, TYPE_CHECKING, Union
+from datetime import date, datetime, time
+import numpy as np
+import pandas as pd
 
 # Python 3.10+ has TypeGuard in typing module, older versions need typing_extensions
 if TYPE_CHECKING:
@@ -13,13 +16,10 @@
         from typing import TypeGuard
     else:
         from typing_extensions import TypeGuard
-from datetime import datetime, date, time
-import pandas as pd
-import numpy as np
 
-from ....compute.ast_temporal import TemporalValue
-from .temporal import NativeTemporal, TemporalWire
+from graphistry.compute.ast_temporal import TemporalValue
 from .numeric import NativeNumeric
+from .temporal import NativeTemporal, TemporalWire
 
 
 # ============= Temporal Detection =============