fix: remove redundant _get function.

Author: MoonBoi9001

packages/subgraph-service/contracts/libraries/Allocation.sol

@@ -97,7 +97,7 @@ library Allocation {
      * @param allocationId The allocation id
      */
     function presentPOI(mapping(address => State) storage self, address allocationId) internal {
-        State storage allocation = _get(self, allocationId);
+        State storage allocation = get(self, allocationId);
         require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
         allocation.lastPOIPresentedAt = block.timestamp;
     }
@@ -115,7 +115,7 @@ library Allocation {
         address allocationId,
         uint256 accRewardsPerAllocatedToken
     ) internal {
-        State storage allocation = _get(self, allocationId);
+        State storage allocation = get(self, allocationId);
         require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
         allocation.accRewardsPerAllocatedToken = accRewardsPerAllocatedToken;
     }
@@ -128,7 +128,7 @@ library Allocation {
      * @param allocationId The allocation id
      */
     function clearPendingRewards(mapping(address => State) storage self, address allocationId) internal {
-        State storage allocation = _get(self, allocationId);
+        State storage allocation = get(self, allocationId);
         require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
         allocation.accRewardsPending = 0;
     }
@@ -141,7 +141,7 @@ library Allocation {
      * @param allocationId The allocation id
      */
     function close(mapping(address => State) storage self, address allocationId) internal {
-        State storage allocation = _get(self, allocationId);
+        State storage allocation = get(self, allocationId);
         require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
         allocation.closedAt = block.timestamp;
     }
@@ -152,7 +152,9 @@ library Allocation {
      * @param allocationId The allocation id
      */
     function get(mapping(address => State) storage self, address allocationId) internal view returns (State memory) {
-        return _get(self, allocationId);
+        State storage allocation = self[allocationId];
+        require(allocation.exists(), AllocationDoesNotExist(allocationId));
+        return allocation;
     }
 
     /**
@@ -189,15 +191,4 @@ library Allocation {
         return self.exists() && self.tokens == 0;
     }
 
-    /**
-     * @notice Get the allocation for an allocation id
-     * @dev Reverts if the allocation does not exist
-     * @param self The allocation list mapping
-     * @param allocationId The allocation id
-     */
-    function _get(mapping(address => State) storage self, address allocationId) private view returns (State storage) {
-        State storage allocation = self[allocationId];
-        require(allocation.exists(), AllocationDoesNotExist(allocationId));
-        return allocation;
-    }
 }

packages/subgraph-service/contracts/libraries/LegacyAllocation.sol

@@ -64,7 +64,7 @@ library LegacyAllocation {
      * @param allocationId The allocation id
      */
     function get(mapping(address => State) storage self, address allocationId) internal view returns (State memory) {
-        return _get(self, allocationId);
+        return get(self, allocationId);
     }
 
     /**
@@ -89,7 +89,7 @@ library LegacyAllocation {
      * @param self The legacy allocation list mapping
      * @param allocationId The allocation id
      */
-    function _get(mapping(address => State) storage self, address allocationId) private view returns (State storage) {
+    function get(mapping(address => State) storage self, address allocationId) private view returns (State storage) {
         State storage allocation = self[allocationId];
         require(allocation.exists(), LegacyAllocationDoesNotExist(allocationId));
         return allocation;