Skip to content

Commit 09637fb

Browse files
urkleLegNeato
andauthored
Un-deprecate the select_child, has_child, and child_names methods (#900)
- Issues with removing them documented in issue #878 Co-authored-by: Christian Legnitto <[email protected]>
1 parent 57165b3 commit 09637fb

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

juniper/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# master
22

3-
- No changes yet
3+
- Un-deprecate select_child, has_child, and child_names methods ([#900]https://github.com/graphql-rust/juniper/pull/#900)
44

55
# [[0.15.3] 2021-01-27](https://github.com/graphql-rust/juniper/releases/tag/juniper-0.15.3)
66

juniper/src/executor/look_ahead.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -340,14 +340,11 @@ pub trait LookAheadMethods<'sel, S> {
340340

341341
/// Get the the child selection for a given field
342342
/// If a child has an alias, it will only match if the alias matches `name`
343-
#[deprecated(note = "please use `children` to access the child selections instead")]
344343
fn select_child(&self, name: &str) -> Option<&Self>;
345344

346345
/// Check if a given child selection with a name exists
347346
/// If a child has an alias, it will only match if the alias matches `name`
348-
#[deprecated(note = "please use `children` to access the child selections instead")]
349347
fn has_child(&self, name: &str) -> bool {
350-
#[allow(deprecated)]
351348
self.select_child(name).is_some()
352349
}
353350

@@ -366,7 +363,6 @@ pub trait LookAheadMethods<'sel, S> {
366363
}
367364

368365
/// Get the (possibly aliased) names of the top level children for the current selection
369-
#[deprecated(note = "please use `children` to access the child selections instead")]
370366
fn child_names(&self) -> Vec<&'sel str>;
371367

372368
/// Get an iterator over the children for the current selection
@@ -1307,7 +1303,6 @@ query Hero {
13071303
}
13081304

13091305
#[test]
1310-
#[allow(deprecated)]
13111306
fn check_select_child() {
13121307
let lookahead: LookAheadSelection<DefaultScalarValue> = LookAheadSelection {
13131308
name: "hero",
@@ -1459,7 +1454,6 @@ fragment heroFriendNames on Hero {
14591454
}
14601455

14611456
#[test]
1462-
#[allow(deprecated)]
14631457
fn check_visitability() {
14641458
let docs = parse_document_source::<DefaultScalarValue>(
14651459
"

0 commit comments

Comments
 (0)