Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export parseRequestParams similar to express-graphql #106

Closed
ritvick opened this issue Aug 3, 2023 · 5 comments · Fixed by #111
Closed

Export parseRequestParams similar to express-graphql #106

ritvick opened this issue Aug 3, 2023 · 5 comments · Fixed by #111
Labels
enhancement New feature or request released Has been released and published

Comments

@ritvick
Copy link

ritvick commented Aug 3, 2023

Story

As a _user

I want parseRequestParams function to be exported

So that same implementation can be used outside the package when interacting with graphql-http.
This was the behaviour in express-graphql implementation.

Acceptance criteria

  • _user I can access parseRequestParams from graphql-http package.
@enisdenjo
Copy link
Member

Interesting request, I'll see what I can do. Thanks!

@enisdenjo enisdenjo added the enhancement New feature or request label Aug 7, 2023
@ritvick
Copy link
Author

ritvick commented Aug 24, 2023

Hi @enisdenjo
I have created a PR here: #110

@enisdenjo enisdenjo mentioned this issue Aug 28, 2023
Merged
@enisdenjo
Copy link
Member

There was more than just exporting the core parser. I've created an improved PR in #111. Thanks for you help though, hope you don't mind!

Nevertheless, a new version will be published soon. Thank you for your patiance.

@enisdenjo
Copy link
Member

🎉 This issue has been resolved in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@enisdenjo enisdenjo added the released Has been released and published label Aug 28, 2023
@ritvick
Copy link
Author

ritvick commented Aug 28, 2023

Thanks for all the help @enisdenjo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released Has been released and published
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(handler): Expose parseRequestParams from the core and each of the adapters graphql/graphql-http
2 participants
@ritvick @enisdenjo